Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: setup.py: Temporarily avoid Sphinx 4 #5649

Merged
merged 1 commit into from
May 11, 2021

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented May 10, 2021

With Sphinx 4.0.0 (released yesterday), the docs builds for maint and
master are failing (with different errors):

https://github.com/datalad/datalad/actions/runs/828244083
https://github.com/datalad/datalad/actions/runs/828227680

Hold off upgrading until the issues are resolved.

With Sphinx 4.0.0 (released yesterday), the docs builds for maint and
master are failing (with different errors):

  https://github.com/datalad/datalad/actions/runs/828244083
  https://github.com/datalad/datalad/actions/runs/828227680

Hold off upgrading until the issues are resolved.
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #5649 (bbd632a) into maint (6c8f2fd) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head bbd632a differs from pull request most recent head cdc2b45. Consider uploading reports for the commit cdc2b45 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5649      +/-   ##
==========================================
- Coverage   84.89%   84.77%   -0.13%     
==========================================
  Files         296      296              
  Lines       42238    42220      -18     
==========================================
- Hits        35859    35790      -69     
- Misses       6379     6430      +51     
Impacted Files Coverage Δ
datalad/support/parallel.py 88.28% <0.00%> (-7.05%) ⬇️
datalad/downloaders/credentials.py 82.35% <0.00%> (-2.95%) ⬇️
datalad/distribution/tests/test_update.py 85.00% <0.00%> (-1.43%) ⬇️
datalad/support/network.py 86.48% <0.00%> (-1.08%) ⬇️
datalad/downloaders/providers.py 94.66% <0.00%> (-0.93%) ⬇️
datalad/tests/test_witless_runner.py 92.85% <0.00%> (-0.90%) ⬇️
datalad/tests/utils.py 77.44% <0.00%> (-0.62%) ⬇️
datalad/distributed/ora_remote.py 31.76% <0.00%> (-0.61%) ⬇️
datalad/ui/dialog.py 87.16% <0.00%> (-0.61%) ⬇️
datalad/downloaders/base.py 77.38% <0.00%> (-0.51%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8f2fd...cdc2b45. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you @kyleam!

@yarikoptic yarikoptic merged commit 6f0540a into datalad:maint May 11, 2021
@kyleam kyleam deleted the avoid-sphinx-4 branch May 11, 2021 12:46
@yarikoptic yarikoptic added semver-patch Increment the patch version when merged semver-internal Changes only affect the internal API and removed semver-patch Increment the patch version when merged labels Jun 2, 2021
@yarikoptic yarikoptic mentioned this pull request Jun 3, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants