Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Honor --on-failure if fetch fails #5671

Merged
merged 3 commits into from
May 18, 2021

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented May 17, 2021

Tweak updates fetch call to

  • avoid deprecated kwargs
  • translate a CommandError to a result record

Closes #3278.
Closes #4154.

GitRepo.fetch's kwargs has been documented as deprecated since
v0.13.0.
update() calls fetch for each dataset it iterates over.  Catch a
CommandError and translate it to a result so that the caller can
decide how to handle the failure with --on-failure.

Closes datalad#3278.
Closes datalad#4154.
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legitimate

I have restarted incomplete appveyor run - we should stop fetching installer from GitHub and just use pip install IMHO

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #5671 (2d526bd) into maint (b38b2b5) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5671      +/-   ##
==========================================
+ Coverage   90.21%   90.32%   +0.10%     
==========================================
  Files         299      299              
  Lines       42328    42344      +16     
==========================================
+ Hits        38185    38246      +61     
+ Misses       4143     4098      -45     
Impacted Files Coverage Δ
datalad/distribution/tests/test_update.py 100.00% <100.00%> (ø)
datalad/distribution/update.py 98.83% <100.00%> (+0.02%) ⬆️
datalad/support/tests/test_annexrepo.py 97.48% <0.00%> (+0.07%) ⬆️
datalad/support/annexrepo.py 91.41% <0.00%> (+0.08%) ⬆️
datalad/tests/test_utils.py 96.33% <0.00%> (+0.40%) ⬆️
datalad/utils.py 85.10% <0.00%> (+0.45%) ⬆️
datalad/ui/dialog.py 87.76% <0.00%> (+0.53%) ⬆️
datalad/tests/test_tests_utils.py 98.90% <0.00%> (+0.54%) ⬆️
datalad/tests/test_log.py 99.30% <0.00%> (+0.69%) ⬆️
datalad/tests/test_witless_runner.py 93.75% <0.00%> (+1.78%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38b2b5...2d526bd. Read the comment docs.

@kyleam kyleam merged commit dd10ecf into datalad:maint May 18, 2021
@kyleam kyleam deleted the update-fetch-fail branch May 18, 2021 13:30
@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Jun 2, 2021
@yarikoptic yarikoptic mentioned this pull request Jun 3, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants