update: Honor --on-failure if fetch fails#5671
Merged
kyleam merged 3 commits intodatalad:maintfrom May 18, 2021
Merged
Conversation
GitRepo.fetch's kwargs has been documented as deprecated since v0.13.0.
update() calls fetch for each dataset it iterates over. Catch a CommandError and translate it to a result so that the caller can decide how to handle the failure with --on-failure. Closes datalad#3278. Closes datalad#4154.
yarikoptic
approved these changes
May 18, 2021
Member
yarikoptic
left a comment
yarikoptic
left a comment
There was a problem hiding this comment.
Looks legitimate
I have restarted incomplete appveyor run - we should stop fetching installer from GitHub and just use pip install IMHO
Codecov Report
@@ Coverage Diff @@
## maint #5671 +/- ##
==========================================
+ Coverage 90.21% 90.32% +0.10%
==========================================
Files 299 299
Lines 42328 42344 +16
==========================================
+ Hits 38185 38246 +61
+ Misses 4143 4098 -45
Continue to review full report at Codecov.
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak
updatesfetchcall tokwargsCommandErrorto a result recordCloses #3278.
Closes #4154.