Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance permission error message for ORA #5683

Merged
merged 1 commit into from Jun 23, 2021

Conversation

bpoldrack
Copy link
Member

With PR #5673 closed, address #5668 by improving error message.

Ping @mih

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #5683 (a1acd98) into master (fd7229a) will decrease coverage by 15.47%.
The diff coverage is 90.05%.

❗ Current head a1acd98 differs from pull request most recent head 3a721ec. Consider uploading reports for the commit 3a721ec to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5683       +/-   ##
===========================================
- Coverage   90.48%   75.01%   -15.48%     
===========================================
  Files         305      305               
  Lines       41883    42151      +268     
===========================================
- Hits        37898    31619     -6279     
- Misses       3985    10532     +6547     
Impacted Files Coverage Δ
datalad/core/distributed/tests/test_clone.py 0.00% <0.00%> (-97.34%) ⬇️
datalad/core/distributed/tests/test_push.py 0.00% <0.00%> (-99.12%) ⬇️
datalad/distributed/ora_remote.py 31.09% <0.00%> (-0.72%) ⬇️
datalad/interface/common_cfg.py 100.00% <ø> (ø)
datalad/interface/tests/test_run_procedure.py 82.00% <ø> (-18.00%) ⬇️
datalad/local/add_readme.py 92.98% <ø> (ø)
datalad/tests/test_utils.py 96.47% <ø> (+0.20%) ⬆️
datalad/tests/utils.py 85.62% <ø> (-2.82%) ⬇️
datalad/distributed/create_sibling_ria.py 82.75% <50.00%> (+0.09%) ⬆️
datalad/core/distributed/push.py 71.54% <66.66%> (-16.98%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7229a...3a721ec. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, I left two comments, please have a look.

datalad/distributed/ora_remote.py Outdated Show resolved Hide resolved
datalad/distributed/ora_remote.py Outdated Show resolved Hide resolved
@mih
Copy link
Member

mih commented Jun 14, 2021

@bpoldrack Can you take this over the finish line. Thx!

@bpoldrack
Copy link
Member Author

@mih Done, I guess.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mih mih merged commit 3fd9f66 into datalad:master Jun 23, 2021
@mih mih deleted the better-err-msg branch June 23, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants