Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: harmonize "purpose" statements to imperative form #5733

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

yarikoptic
Copy link
Member

We had a mix, and even though "ing form was probably more prevalent, I felt that shorter
imperative form would be better, even though it would be not "for {purpose}" but
"to {purpose}" if to be displayed. (as eg in #5708)

We had a mix, and even though "ing form was probably more prevalent, I felt that shorter
imperative form would be better, even though it would be not "for {purpose}" but
"to {purpose}" if to be displayed. (as eg in datalad#5708)
@yarikoptic yarikoptic added UX user experience DX developer experience labels Jun 10, 2021
@bpoldrack
Copy link
Member

Nice. Don't give anything about which form, but harmonizing it certainly is desirable. :)

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #5733 (053e620) into maint (8c158c5) will decrease coverage by 35.06%.
The diff coverage is 75.00%.

❗ Current head 053e620 differs from pull request most recent head 38a454e. Consider uploading reports for the commit 38a454e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            maint    #5733       +/-   ##
===========================================
- Coverage   90.30%   55.24%   -35.07%     
===========================================
  Files         299      296        -3     
  Lines       42353    42317       -36     
===========================================
- Hits        38247    23376    -14871     
- Misses       4106    18941    +14835     
Impacted Files Coverage Δ
datalad/core/distributed/clone.py 89.84% <ø> (-1.78%) ⬇️
datalad/core/distributed/push.py 88.52% <ø> (ø)
datalad/core/local/create.py 92.36% <ø> (-0.70%) ⬇️
datalad/core/local/diff.py 89.58% <ø> (-1.05%) ⬇️
datalad/core/local/run.py 91.18% <ø> (-7.93%) ⬇️
datalad/core/local/status.py 91.96% <ø> (-4.47%) ⬇️
datalad/distributed/create_sibling_ria.py 64.11% <ø> (-18.24%) ⬇️
datalad/distributed/export_archive_ora.py 38.46% <ø> (-43.08%) ⬇️
datalad/distribution/create_sibling.py 45.91% <ø> (-40.01%) ⬇️
datalad/distribution/create_sibling_github.py 35.93% <ø> (-48.44%) ⬇️
... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c158c5...38a454e. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! thx!

Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it too!

@yarikoptic yarikoptic merged commit 2d24b9f into datalad:maint Jun 11, 2021
@yarikoptic yarikoptic deleted the enh-harmonize-purpose branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX developer experience UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants