ENH(TST): populate heavy tree with 100 unique keys (not just 1) among 10,000 #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. |
It still managed to hang my VM running out of the space. So I will see if appveyor CI handles it better.
Codecov Report
@@ Coverage Diff @@
## maint #5734 +/- ##
==========================================
- Coverage 90.30% 83.69% -6.62%
==========================================
Files 299 296 -3
Lines 42353 41215 -1138
==========================================
- Hits 38247 34495 -3752
- Misses 4106 6720 +2614
Continue to review full report at Codecov.
|
yarikoptic
commented
Jun 10, 2021
| @@ -2385,7 +2396,7 @@ def check_files_split(cls, topdir): | |||
| dl.save(dataset=r.path, path=dirs) | |||
|
|
|||
|
|
|||
| @known_failure_windows # does not find files to add (too long paths?) | |||
| # @known_failure_windows # might fail with some older annex `cp` failing to set permissions | |||
There was a problem hiding this comment.
it seems to happily run it on appveyor now
(git)smaug:/mnt/btrfs/datasets/datalad/ci/logs/2021/06[master]10
$> grep test_files_split pr/5734/f11a3fe/appveyor-6136-success/*
pr/5734/f11a3fe/appveyor-6136-success/2a7fac7mhfxqdhc8.txt:[00:26:20] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2a7fac7mhfxqdhc8.txt:[00:26:36] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2a7fac7mhfxqdhc8.txt:[00:27:02] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2a7fac7mhfxqdhc8.txt:[00:28:55] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2b2con1jce8cna36.txt:[00:17:25] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2b2con1jce8cna36.txt:[00:17:47] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2b2con1jce8cna36.txt:[00:18:29] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/2b2con1jce8cna36.txt:[00:24:00] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/4mq5uh9l1e2edtii.txt:[00:12:49] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/4mq5uh9l1e2edtii.txt:[00:13:43] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/4mq5uh9l1e2edtii.txt:[00:13:46] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/4mq5uh9l1e2edtii.txt:[00:25:38] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/wi1bdfqu682mpp1e.txt:[00:27:42] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/wi1bdfqu682mpp1e.txt:[00:27:54] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/wi1bdfqu682mpp1e.txt:[00:28:19] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/wi1bdfqu682mpp1e.txt:[00:30:09] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/yl3m216fnici99d2.txt:[00:26:21] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/yl3m216fnici99d2.txt:[00:26:36] datalad.support.tests.test_annexrepo.test_files_split_exc(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/yl3m216fnici99d2.txt:[00:27:02] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.gitrepo.GitRepo'>,) ... ok
pr/5734/f11a3fe/appveyor-6136-success/yl3m216fnici99d2.txt:[00:28:54] datalad.support.tests.test_annexrepo.test_files_split(<class 'datalad.support.annexrepo.AnnexRepo'>,) ... ok
|
ok, it is still green, even appveyor is running it now (although in a trimmed configuration), so let's proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would still fit the purpose of the test (long lists of files) while possibly avoid annex taking too long to deal with 10,000 copies of the same file (unrealistic scenario IMHO). We would still have 100 unique keys (not 10,000) so file system would not get tortured that heavily to populate all the
.git/annex/objects.Ref: https://git-annex.branchable.com/bugs/significant_performance_regression_impacting_datal/