Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lock file location configurable #5740

Merged
merged 1 commit into from Jun 15, 2021
Merged

Make lock file location configurable #5740

merged 1 commit into from Jun 15, 2021

Conversation

bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Jun 14, 2021

This introduces datalad.locations.locks to specify the location to be
used for (global) lock files. Defaults to the currently used
<user cache dir>/locks.

Closes #5706

This introduces `datalad.locations.locks` to specify the location to be
used for (global) lock files. Defaults to the currently used
`<user cache dir>/locks`.

Closes datalad#5706
@bpoldrack
Copy link
Member Author

Hopefully uncontroversial, so assuming tests get back green - ready to merge from my POV.

@bpoldrack bpoldrack added the merge-if-ok OP considers this work done, and requests review/merge label Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #5740 (b6ac4ca) into master (0b0e7fe) will decrease coverage by 20.67%.
The diff coverage is 100.00%.

❗ Current head b6ac4ca differs from pull request most recent head e9f2fc9. Consider uploading reports for the commit e9f2fc9 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5740       +/-   ##
===========================================
- Coverage   90.63%   69.96%   -20.68%     
===========================================
  Files         308      305        -3     
  Lines       42168    42145       -23     
===========================================
- Hits        38220    29485     -8735     
- Misses       3948    12660     +8712     
Impacted Files Coverage Δ
datalad/downloaders/base.py 50.88% <ø> (-27.72%) ⬇️
datalad/interface/common_cfg.py 100.00% <ø> (ø)
datalad/local/add_readme.py 92.98% <ø> (ø)
datalad/config.py 96.71% <100.00%> (ø)
datalad/core/distributed/clone.py 91.83% <100.00%> (-0.13%) ⬇️
datalad/core/distributed/tests/test_clone.py 97.34% <100.00%> (+0.01%) ⬆️
datalad/local/tests/test_add_readme.py 100.00% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0e7fe...e9f2fc9. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. appveyor fails to run on Macs is appveyor issue unrelated to this PR.

FWIW, I would not even mind it in maint which we might kick out some time sooner than master.

@mih mih merged commit e16663b into datalad:master Jun 15, 2021
@mih
Copy link
Member

mih commented Jun 15, 2021

Thx!

@mih mih deleted the gh-5706 branch June 15, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce specific config setting for lock file location
3 participants