Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Report the sibling name in create-sibling-github's results record #5744

Merged
merged 1 commit into from Jun 15, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Jun 14, 2021

Here's my attempt at reporting a sibling name when a GitHub sibling is created, as desired in #5711. Its not a separate key in the result, but merely added into the message, but I found that it looked quite crowded when I rendered several messages.
Here is the current look:
Screenshot from 2021-06-14 15-37-24

Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just would like to see a different title since it appears in the changelog. THis is not about result rendering. You just changed the message in the possibly-to-be-rendered result record.

@adswa adswa changed the title UX: Report the sibling name in result rendering for create-sibling-github UX: Report the sibling name in create-sibling-github's results record Jun 14, 2021
@adswa
Copy link
Member Author

adswa commented Jun 14, 2021

better like this, @bpoldrack?

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #5744 (858f088) into master (f5b6db0) will decrease coverage by 2.57%.
The diff coverage is 100.00%.

❗ Current head 858f088 differs from pull request most recent head be4b3c1. Consider uploading reports for the commit be4b3c1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
- Coverage   90.63%   88.06%   -2.58%     
==========================================
  Files         308      305       -3     
  Lines       42181    42163      -18     
==========================================
- Hits        38231    37130    -1101     
- Misses       3950     5033    +1083     
Impacted Files Coverage Δ
datalad/distribution/create_sibling_github.py 93.44% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b6db0...be4b3c1. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants