Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH (UX): add python-gitlab dependency #5776

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

jsheunis
Copy link
Member

Fixes #4344

Adds python-gitlab to setup.py so that it does not have to be installed manually when users want to run create-sibling-gitlab

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #5776 (5f90005) into maint (985413a) will decrease coverage by 36.66%.
The diff coverage is 55.55%.

❗ Current head 5f90005 differs from pull request most recent head aa50e9e. Consider uploading reports for the commit aa50e9e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            maint    #5776       +/-   ##
===========================================
- Coverage   89.89%   53.22%   -36.67%     
===========================================
  Files         299      297        -2     
  Lines       42350    42302       -48     
===========================================
- Hits        38069    22515    -15554     
- Misses       4281    19787    +15506     
Impacted Files Coverage Δ
datalad/core/distributed/clone.py 89.84% <ø> (-0.26%) ⬇️
datalad/core/distributed/push.py 88.52% <ø> (ø)
datalad/core/local/create.py 92.36% <ø> (-0.70%) ⬇️
datalad/core/local/diff.py 90.62% <ø> (ø)
datalad/core/local/run.py 98.23% <ø> (-0.89%) ⬇️
datalad/core/local/status.py 96.42% <ø> (ø)
datalad/distributed/create_sibling_ria.py 59.41% <ø> (-22.95%) ⬇️
datalad/distributed/export_archive_ora.py 38.46% <ø> (-43.08%) ⬇️
datalad/distribution/create_sibling.py 47.60% <ø> (-38.31%) ⬇️
datalad/distribution/create_sibling_github.py 84.37% <ø> (ø)
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f5c58...aa50e9e. Read the comment docs.

@mih
Copy link
Member

mih commented Jul 6, 2021

CI failure is unrelated. No need to rerun

@mih mih added the semver-patch Increment the patch version when merged label Jul 6, 2021
@mih mih merged commit 4eb4154 into datalad:maint Jul 6, 2021
@yarikoptic yarikoptic added this to the 0.14.5 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants