Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell-completion: add argcomplete to 'misc' extra_depends, log an ERROR if argcomplete fails to import #5781

Merged
merged 3 commits into from Jul 7, 2021

Conversation

yarikoptic
Copy link
Member

$> datalad shell-completion > /dev/null
[ERROR] argcomplete failed to import - completions unlikely to work. Check if it is installed: No module named 'argcomplete' [shell_completion.py:__call__:51]

Motivator: ruedin as of https://neurostars.org/t/tab-completion-not-working-with-datalad-commands/19683/3?u=yarikoptic

    $> datalad shell-completion > /dev/null
    [ERROR] argcomplete failed to import - completions unlikely to work. Check if it is installed: No module named 'argcomplete' [shell_completion.py:__call__:51]

Motivator: ruedin as of https://neurostars.org/t/tab-completion-not-working-with-datalad-commands/19683/3?u=yarikoptic
@yarikoptic yarikoptic added UX user experience semver-patch Increment the patch version when merged labels Jul 3, 2021
@kimsin98
Copy link
Contributor

kimsin98 commented Jul 7, 2021

I was also wondering why the script from datalad shell-completion was not working.

I think argcomplete should be included as an optional dependency in setup and/or explicit mentioned as a separate dependency in shell-completion docs.

@mih
Copy link
Member

mih commented Jul 7, 2021

I agree. I don't see why it should not be a declared dependency, given the current list of deps.

@yarikoptic
Copy link
Member Author

indeed! I have not realized it was not listed. Added to misc (so part of pip install datalad[full]) in 2c74fd9

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #5781 (0154595) into maint (985413a) will decrease coverage by 4.95%.
The diff coverage is 76.47%.

❗ Current head 0154595 differs from pull request most recent head 2c74fd9. Consider uploading reports for the commit 2c74fd9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5781      +/-   ##
==========================================
- Coverage   89.89%   84.93%   -4.96%     
==========================================
  Files         299      297       -2     
  Lines       42350    42327      -23     
==========================================
- Hits        38069    35952    -2117     
- Misses       4281     6375    +2094     
Impacted Files Coverage Δ
datalad/core/distributed/clone.py 91.62% <ø> (+1.52%) ⬆️
datalad/core/distributed/push.py 88.52% <ø> (ø)
datalad/core/local/create.py 92.36% <ø> (-0.70%) ⬇️
datalad/core/local/diff.py 90.62% <ø> (ø)
datalad/core/local/run.py 98.23% <ø> (-0.89%) ⬇️
datalad/core/local/status.py 96.42% <ø> (ø)
datalad/distributed/create_sibling_ria.py 82.35% <ø> (ø)
datalad/distributed/export_archive_ora.py 81.53% <ø> (ø)
datalad/distribution/create_sibling.py 82.81% <ø> (-3.10%) ⬇️
datalad/distribution/create_sibling_github.py 84.37% <ø> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f5c58...2c74fd9. Read the comment docs.

@yarikoptic
Copy link
Member Author

I think fails are unrelated (due to newer annex on osx) and I will proceed with the merge

@yarikoptic yarikoptic changed the title ENH: log an ERROR if argcomplete fails to import shell-completion: add argcomplete to 'misc' extra_depends, log an ERROR if argcomplete fails to import Jul 7, 2021
@yarikoptic yarikoptic merged commit f779163 into datalad:maint Jul 7, 2021
@yarikoptic yarikoptic added this to the 0.14.5 milestone Jul 8, 2021
@yarikoptic yarikoptic deleted the enh-shell-completion branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants