Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH(UX,DX): inform user with a warning if version is 0+unknown #5787

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Jul 8, 2021

A possible to encounter side-effect from using versioneer. See
#5785
for more information. Overall I take it to Closes #5785

Results in

$> python -c 'import datalad'                    
[WARNING] DataLad was not installed 'properly' so its version is an uninformative '0+unknown'.
| It can happen e.g. if datalad was installed via
|   pip install https://github.com/.../archive/{commitish}.zip
| instead of
|   pip install git+https://github.com/...@{commitish} .
| We advise to re-install datalad or downstream projects might not operate correctly. 

I think that is good enough/better than nothing ;)

edit: fix for datalad/git-annex workflows is coming in datalad/git-annex#72

A possible to encounter side-effect from using versioneer.  See
datalad#5785
for more information
@yarikoptic yarikoptic added UX user experience DX developer experience semver-patch Increment the patch version when merged labels Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #5787 (f06e4c3) into maint (f779163) will decrease coverage by 5.53%.
The diff coverage is 85.71%.

❗ Current head f06e4c3 differs from pull request most recent head 4c41557. Consider uploading reports for the commit 4c41557 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5787      +/-   ##
==========================================
- Coverage   90.33%   84.80%   -5.54%     
==========================================
  Files         300      297       -3     
  Lines       42345    42313      -32     
==========================================
- Hits        38253    35883    -2370     
- Misses       4092     6430    +2338     
Impacted Files Coverage Δ
datalad/__init__.py 79.57% <66.66%> (-6.34%) ⬇️
datalad/cmdline/tests/test_main.py 96.32% <100.00%> (-2.21%) ⬇️
datalad/support/tests/test_external_versions.py 95.59% <100.00%> (+0.05%) ⬆️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
datalad/metadata/extractors/xmp.py 12.96% <0.00%> (-79.63%) ⬇️
datalad/metadata/extractors/exif.py 18.75% <0.00%> (-78.13%) ⬇️
datalad/metadata/extractors/image.py 19.35% <0.00%> (-77.42%) ⬇️
datalad/metadata/extractors/audio.py 20.00% <0.00%> (-77.15%) ⬇️
datalad/metadata/extractors/tests/test_exif.py 24.00% <0.00%> (-76.00%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f779163...4c41557. Read the comment docs.

@yarikoptic
Copy link
Member Author

@datalad/developers please give your blessing or feedback.

@yarikoptic yarikoptic added this to the 0.14.5 milestone Jul 8, 2021
@adswa
Copy link
Member

adswa commented Jul 11, 2021

I think that is good enough/better than nothing ;)

I agree.

@yarikoptic
Copy link
Member Author

travis error -- conda install, appveyor -- osx'es so I guess all the annex regressions reported elsewhere, lets' proceed

@yarikoptic yarikoptic merged commit 612375e into datalad:maint Jul 11, 2021
@yarikoptic yarikoptic deleted the bf-tests-version-comparisons2 branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX developer experience semver-patch Increment the patch version when merged UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants