Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: create-sibling-gitlab: do not skip root dataset when path is given #5789

Merged
merged 1 commit into from Jul 20, 2021

Conversation

mih
Copy link
Member

@mih mih commented Jul 14, 2021

Before datalad create-sibling-gitlab . would just do nothing.
Now the root dataset is processed if a given path matches it.

Fixes #5763

@mih mih added the UX user experience label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #5789 (d17652f) into master (86a55c8) will decrease coverage by 1.97%.
The diff coverage is 100.00%.

❗ Current head d17652f differs from pull request most recent head 573c6c1. Consider uploading reports for the commit 573c6c1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
- Coverage   90.64%   88.66%   -1.98%     
==========================================
  Files         309      306       -3     
  Lines       42385    42366      -19     
==========================================
- Hits        38418    37565     -853     
- Misses       3967     4801     +834     
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gitlab.py 74.67% <100.00%> (ø)
...ad/distributed/tests/test_create_sibling_gitlab.py 100.00% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a55c8...573c6c1. Read the comment docs.

@mih
Copy link
Member Author

mih commented Jul 15, 2021

A whole range of unrelated, heterogeneous failures on MacOS.

Before `datalad create-sibling-gitlab .` would just do nothing.
Now the root dataset is processed if a given path matches it.

Fixes datalad#5763
@mih
Copy link
Member Author

mih commented Jul 17, 2021

Test failure is unrelated #5794

@mih mih requested a review from yarikoptic July 17, 2021 09:50
@mih
Copy link
Member Author

mih commented Jul 20, 2021

Happy all around!

@mih mih merged commit be5c49e into datalad:master Jul 20, 2021
@mih mih deleted the bf-5763 branch July 20, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-sibling-gitlab does not talk and does not do (at times)
2 participants