Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: ORA incorrectly handled redirects #5792

Merged
merged 1 commit into from Jul 17, 2021
Merged

Conversation

bpoldrack
Copy link
Member

The ORA special remote's HEAD request was send w/o
allow_redirects=True, which defaults to False. This led CHECKPRESENT
requests to fail.

Closes #5616

The ORA special remote's HEAD request was send w/o
`allow_redirects=True`, which defaults to False. This led CHECKPRESENT
requests to fail.

(Closes datalad#5616)
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, much appreciated! This should aid anyone with a large pile of datasets configured to use HTTP, when the infrastructure moves to HTTPS only.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #5792 (9fffd83) into master (86a55c8) will decrease coverage by 1.81%.
The diff coverage is 0.00%.

❗ Current head 9fffd83 differs from pull request most recent head f8a4906. Consider uploading reports for the commit f8a4906 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5792      +/-   ##
==========================================
- Coverage   90.64%   88.82%   -1.82%     
==========================================
  Files         309      306       -3     
  Lines       42385    42367      -18     
==========================================
- Hits        38418    37632     -786     
- Misses       3967     4735     +768     
Impacted Files Coverage Δ
datalad/distributed/ora_remote.py 31.49% <0.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a55c8...f8a4906. Read the comment docs.

@mih
Copy link
Member

mih commented Jul 17, 2021

Unrelated test failure, filed #5794

@mih mih merged commit 7ea9afa into datalad:master Jul 17, 2021
@mih mih deleted the gh-5616 branch July 17, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORA http redirection not supported
2 participants