Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust wording of MissingExternalDependency error #5803

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Jul 21, 2021

The new phrasing should better cover the case of an existing installation
that is nevertheless broken, and fails an import test.

Fixes #5729

The new phrasing should better cover the case of an existing installation
that is nevertheless broken, and fails an import test.

Fixes datalad#5729
Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better than the previous message to me.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #5803 (43018f1) into master (0b2d882) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5803      +/-   ##
==========================================
+ Coverage   90.62%   90.64%   +0.02%     
==========================================
  Files         309      309              
  Lines       42392    42436      +44     
==========================================
+ Hits        38417    38468      +51     
+ Misses       3975     3968       -7     
Impacted Files Coverage Δ
datalad/support/exceptions.py 85.12% <100.00%> (ø)
datalad/cmdline/tests/test_main.py 96.63% <0.00%> (-0.61%) ⬇️
datalad/__init__.py 86.70% <0.00%> (-0.56%) ⬇️
datalad/cmd.py 91.20% <0.00%> (-0.09%) ⬇️
datalad/core/distributed/push.py 92.49% <0.00%> (-0.03%) ⬇️
datalad/support/gitrepo.py 91.99% <0.00%> (-0.02%) ⬇️
datalad/nonasyncrunner.py 100.00% <0.00%> (ø)
datalad/interface/__init__.py 100.00% <0.00%> (ø)
datalad/cmdline/tests/test_helpers.py 100.00% <0.00%> (ø)
datalad/distributed/create_sibling_gitlab.py 74.67% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2d882...43018f1. Read the comment docs.

@mih
Copy link
Member Author

mih commented Jul 23, 2021

Thx @adswa !

@mih mih merged commit cbe671c into datalad:master Jul 23, 2021
@mih mih deleted the bf-5729 branch July 23, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian package dependency issue with python3-github
2 participants