Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF(TST): do not test for no EASY and pkg_resources in shims #5817

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

yarikoptic
Copy link
Member

Awhile back we did switch away from creating our own entry point
scripts, and just succumbed to all the goodness default mechanisms
give us. We had to skip this test on debian builds, where we have
to run something like setup.py develop to produce those entry points
for the tests. That added up burden etc. So I decided we should no
longer bother with such tests, also because pkg_resources now used
just as a fall back in those produced by setuptools, so typically there
should be no big penalty in start time.

Closes #5384

Awhile back we did switch away from creating our own entry point
scripts, and just succumbed to all the goodness default mechanisms
give us.  We had to skip this test on debian builds, where we have
to run something like   setup.py develop  to produce those entry points
for the tests.  That added up burden etc.  So I decided we should no
longer bother with such tests, also because pkg_resources now used
just as a fall back in those produced by setuptools, so typically there
should be no big penalty in start time.

Closes datalad#5384
@mih
Copy link
Member

mih commented Jul 26, 2021

Filed #5819 for the test failure. Remaining failure is known and unrelated (mac os CI fragility).

@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Jul 26, 2021
@yarikoptic
Copy link
Member Author

ok, no objections, tests fails unrelated, let's proceed

@yarikoptic yarikoptic merged commit b809936 into datalad:maint Jul 26, 2021
yarikoptic added a commit that referenced this pull request Jul 26, 2021
@yarikoptic yarikoptic deleted the enh-relax-script-test branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants