Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove publish from -core (placed into datalad_deprecated) #5837

Merged
merged 4 commits into from Aug 15, 2021

Conversation

mih
Copy link
Member

@mih mih commented Jul 29, 2021

Acting on #4493, this PR remove the publish command, deprecated in 0.13.

This is also a push towards an eventual resolution of #3368

Companion PR in -deprecated is datalad/datalad-deprecated#28 and it is ready to be merged.

Looks as if we get a 2-8 min reduction in CI run time on appveyor (for those that execute the distribution tests).

mih added 3 commits July 29, 2021 09:27
It is removed from -core, but actually moved to -deprecated, as
requested by @yoh.

Fixes datalad#4493
One test (`test_target_ssh_inherit`) is too tighly coupled to `publish`,
make it dependent on the presence of `datalad_deprecated` and its
`publish()`.
No longer available in -core. But also no closely relevant, because
`git-annex` is shown in the code example.
@mih mih linked an issue Jul 29, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #5837 (bca0c47) into master (b8357e9) will decrease coverage by 55.87%.
The diff coverage is 22.85%.

❗ Current head bca0c47 differs from pull request most recent head e849b02. Consider uploading reports for the commit e849b02 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5837       +/-   ##
===========================================
- Coverage   90.63%   34.76%   -55.88%     
===========================================
  Files         310      305        -5     
  Lines       42472    41785      -687     
===========================================
- Hits        38496    14525    -23971     
- Misses       3976    27260    +23284     
Impacted Files Coverage Δ
datalad/distributed/tests/test_ria.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/tests/test_create_sibling.py 0.00% <0.00%> (-87.62%) ⬇️
datalad/distribution/tests/test_install.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/tests/test_update.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/__init__.py 100.00% <ø> (ø)
datalad/metadata/tests/test_aggregation.py 0.00% <0.00%> (-99.09%) ⬇️
datalad/support/tests/test_gitrepo.py 0.00% <0.00%> (-99.90%) ⬇️
datalad/tests/test_version.py 0.00% <ø> (-27.78%) ⬇️
datalad/core/distributed/tests/test_clone.py 97.04% <100.00%> (-0.39%) ⬇️
datalad/support/gitrepo.py 75.89% <100.00%> (-16.10%) ⬇️
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8357e9...e849b02. Read the comment docs.

@mih mih added the merge-if-ok OP considers this work done, and requests review/merge label Jul 29, 2021
@mih
Copy link
Member Author

mih commented Jul 30, 2021

datalad/datalad-deprecated#28 is now merged. I restarted the -deprecated tests in this PR.

@mih
Copy link
Member Author

mih commented Aug 5, 2021

There have been no comments for a week. I assume everybody is OK to move forward.

@mih mih added the semver-minor Increment the minor version when merged label Aug 5, 2021
@mih
Copy link
Member Author

mih commented Aug 15, 2021

OK, another 10 day later still all quiet....

Till infinity, and beyond!

@mih mih merged commit 7983047 into datalad:master Aug 15, 2021
@mih mih deleted the mnt-removepublish branch August 15, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove publish command
1 participant