Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project URLs into the package metadata for convenience links on Pypi #5866

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Aug 4, 2021

This PR adds optional package metadata in the form of project_urls. I believe they would show up on pypi.org in the side bar, making it easier to find documentation, source, or bug tracker. Fixes #5865

@adswa adswa added semver-internal Changes only affect the internal API documentation Documentation-related issue labels Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #5866 (dd3266b) into maint (7f543d0) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5866      +/-   ##
==========================================
+ Coverage   90.28%   90.34%   +0.06%     
==========================================
  Files         300      300              
  Lines       42370    42390      +20     
==========================================
+ Hits        38252    38297      +45     
+ Misses       4118     4093      -25     
Impacted Files Coverage Δ
datalad/downloaders/http.py 79.15% <0.00%> (-1.29%) ⬇️
datalad/core/distributed/tests/test_push.py 98.90% <0.00%> (-0.22%) ⬇️
datalad/distribution/tests/test_get.py 100.00% <0.00%> (ø)
datalad/plugin/tests/test_addurls.py 99.54% <0.00%> (+<0.01%) ⬆️
datalad/distribution/get.py 97.92% <0.00%> (+0.01%) ⬆️
datalad/tests/test_utils.py 96.46% <0.00%> (+0.13%) ⬆️
datalad/core/distributed/tests/test_clone.py 97.37% <0.00%> (+0.13%) ⬆️
datalad/support/sshconnector.py 87.81% <0.00%> (+0.35%) ⬆️
datalad/support/tests/test_annexrepo.py 97.48% <0.00%> (+0.43%) ⬆️
datalad/tests/utils.py 89.39% <0.00%> (+0.61%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f543d0...dd3266b. Read the comment docs.

setup.py Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member

@jwodder -- please share your wisdom on this PR -- will it result in desired effect on pypi?

@yarikoptic yarikoptic requested a review from jwodder August 4, 2021 19:07
@jwodder
Copy link
Member

jwodder commented Aug 4, 2021

@yarikoptic Yes.

Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
setup.py Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member

uff, all green now, let's proceed!

@yarikoptic yarikoptic merged commit 6529f05 into datalad:maint Aug 5, 2021
@adswa adswa deleted the doc-links branch August 5, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation-related issue semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants