BF: take path from SSHRI, test URLs not only on Windows#5881
Merged
bpoldrack merged 1 commit intodatalad:maintfrom Aug 11, 2021
Merged
BF: take path from SSHRI, test URLs not only on Windows#5881bpoldrack merged 1 commit intodatalad:maintfrom
bpoldrack merged 1 commit intodatalad:maintfrom
Conversation
While extending test with SSH RIs I realized that a + b if False else d == d, so in effect those example URLs were tested only on Windows. I have made it a bit more explicit so we do not fall into this trap again. Closes datalad#5880
yarikoptic
added a commit
to yarikoptic/datalad
that referenced
this pull request
Aug 9, 2021
Would rely on RI to have non-degenerating .path, or .hostname, and only then (ab)use entire URL as path, taking the last component A complimentary/alternative to a bug fix for SSH in datalad#5881 and sits on top of it
Codecov Report
@@ Coverage Diff @@
## maint #5881 +/- ##
==========================================
- Coverage 90.34% 90.32% -0.02%
==========================================
Files 300 300
Lines 42395 42396 +1
==========================================
- Hits 38301 38294 -7
- Misses 4094 4102 +8
Continue to review full report at Codecov.
|
bpoldrack
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While extending test with SSH RIs I realized that
(a + b if False else d) == d, so in effect those example URLswere tested only on Windows. I have made it a bit more explicit so
we do not fall into this trap again.
Closes #5880
_get_installationpath_from_urlto avoid any class checks. Logic should not rely on the class, but rather on eitherpathis provided IMHO. I might submit a follow up PR against master, wanted to keep this PR to the point