.travis.yml: use python -m {nose,coverage} invocations, and always show combined report#5888
Merged
yarikoptic merged 3 commits intodatalad:maintfrom Aug 12, 2021
Merged
Conversation
so we could assess if anything (in coverage) has changed.
Adjusted comment to be more reflective of reasoning etc
nosetests etc. so it would be more aligned how it is likely invoked locally, and there is no possibility for mixing up pythons etc.
Codecov Report
@@ Coverage Diff @@
## maint #5888 +/- ##
==========================================
+ Coverage 90.32% 90.34% +0.02%
==========================================
Files 300 300
Lines 42396 42396
==========================================
+ Hits 38293 38302 +9
+ Misses 4103 4094 -9
Continue to review full report at Codecov.
|
Member
Author
|
hm... such total greenness is worrisome since we usually expect lower coverage -- did I fix something as a side effect? ;-) edit: coverage in utils.py jumped because it managed to get submitted from OSX judging from https://app.codecov.io/gh/datalad/datalad/compare/5888/changes#D1L943 |
yarikoptic
added
the
merge-if-ok
Member
Author
|
since only got better etc, I will just proceed with merge |
yarikoptic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual commits say more. I do not expect any effect on coverage.