Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: use python -m {nose,coverage} invocations, and always show combined report #5888

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

yarikoptic
Copy link
Member

Individual commits say more. I do not expect any effect on coverage.

so we could assess if anything (in coverage) has changed.
Adjusted comment to be more reflective of reasoning etc
nosetests etc.  so it would be more aligned how it is likely invoked locally,
and there is no possibility for mixing up pythons etc.
@yarikoptic yarikoptic added the semver-internal Changes only affect the internal API label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5888 (0d70777) into maint (2d53dd1) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5888      +/-   ##
==========================================
+ Coverage   90.32%   90.34%   +0.02%     
==========================================
  Files         300      300              
  Lines       42396    42396              
==========================================
+ Hits        38293    38302       +9     
+ Misses       4103     4094       -9     
Impacted Files Coverage Δ
datalad/distributed/ora_remote.py 32.37% <0.00%> (+0.35%) ⬆️
datalad/distributed/tests/test_ria_basics.py 98.36% <0.00%> (+0.40%) ⬆️
datalad/tests/utils.py 89.39% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d53dd1...0d70777. Read the comment docs.

@yarikoptic
Copy link
Member Author

yarikoptic commented Aug 12, 2021

hm... such total greenness is worrisome since we usually expect lower coverage -- did I fix something as a side effect? ;-)

edit: coverage in utils.py jumped because it managed to get submitted from OSX judging from https://app.codecov.io/gh/datalad/datalad/compare/5888/changes#D1L943

@yarikoptic yarikoptic added the merge-if-ok OP considers this work done, and requests review/merge label Aug 12, 2021
@yarikoptic
Copy link
Member Author

since only got better etc, I will just proceed with merge

@yarikoptic yarikoptic changed the title Minor refactorings to .travis.yml .travis.yml: use python -m {nose,coverage} invocations, and always show combined report Aug 12, 2021
@yarikoptic yarikoptic merged commit 513c753 into datalad:maint Aug 12, 2021
@yarikoptic yarikoptic deleted the rf-travis branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant