Skip to content

BF(TST): Boost version of git-annex to 8.20201129 to test an error message#5894

Merged
yarikoptic merged 1 commit intodatalad:maintfrom
yarikoptic:bf-test-expect-export-msg
Aug 14, 2021
Merged

BF(TST): Boost version of git-annex to 8.20201129 to test an error message#5894
yarikoptic merged 1 commit intodatalad:maintfrom
yarikoptic:bf-test-expect-export-msg

Conversation

@yarikoptic
Copy link
Member

By no means I did thorough investigation but

  • test currently fails on cron (and locally) if I do have 8.20200309 installed

  • last change to that line/logic is from later -- so I decided to go with that one

    $> git blame Remote/Helper/ExportImport.hs | grep 'use .git-annex export'
    9a2c8757f3 Remote/Helper/ExportImport.hs (Joey Hess 2020-12-18 14:52:57 -0400 153) then giveup "remote is configured with exporttree=yes; use git-annex export to store content on it"
    $> git describe --contains 9a2c8757f3
    8.2020112930^222

    someone else is welcome to bisect closer if that is not the version

refs:

@yarikoptic yarikoptic changed the base branch from master to maint August 14, 2021 15:37
@yarikoptic yarikoptic added the tests Add or improve existing tests label Aug 14, 2021
…to get msg out

By no means I did thorough investigation but

- test currently fails on cron (and locally) if I do have 8.20200309 installed

- last change to that line/logic is from later -- so I decided to go with that one

	$> git blame Remote/Helper/ExportImport.hs | grep 'use .git-annex export'
	9a2c8757f3 Remote/Helper/ExportImport.hs (Joey Hess 2020-12-18 14:52:57 -0400 153) 					then giveup "remote is configured with exporttree=yes; use `git-annex export` to store content on it"
	$> git describe --contains 9a2c8757f3
	8.20201129~30^2~22

  someone else is welcome to bisect closer if that is not the version

refs:
- prior discussion datalad#5809 (comment)
- Closes datalad#5879
@yarikoptic yarikoptic force-pushed the bf-test-expect-export-msg branch from bb14141 to 1e0c99d Compare August 14, 2021 15:38
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #5894 (1e0c99d) into maint (2d53dd1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5894      +/-   ##
==========================================
+ Coverage   90.32%   90.34%   +0.02%     
==========================================
  Files         300      300              
  Lines       42396    42396              
==========================================
+ Hits        38293    38302       +9     
+ Misses       4103     4094       -9     
Impacted Files Coverage Δ
datalad/cmdline/tests/test_main.py 98.61% <100.00%> (ø)
datalad/distributed/ora_remote.py 32.37% <0.00%> (+0.35%) ⬆️
datalad/distributed/tests/test_ria_basics.py 98.36% <0.00%> (+0.40%) ⬆️
datalad/tests/utils.py 89.39% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d53dd1...1e0c99d. Read the comment docs.

@yarikoptic yarikoptic changed the title BF(TST): Boost version of git-annex to test matching the last change to get msg out BF(TST): Boost version of git-annex to 8.20201129 to test an error message Aug 14, 2021
@yarikoptic yarikoptic merged commit 7d1f2bf into datalad:maint Aug 14, 2021
@yarikoptic yarikoptic deleted the bf-test-expect-export-msg branch August 18, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_commanderror_jsonmsgs fails when tested against our minimal GIT_ANNEX_MIN_VERSION = '8.20200309'

1 participant