Limit use of default annex.retry=3 to get and copy operations
#5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5904 +/- ##
===========================================
- Coverage 90.21% 47.15% -43.07%
===========================================
Files 308 305 -3
Lines 41931 41895 -36
===========================================
- Hits 37827 19754 -18073
- Misses 4104 22141 +18037
Continue to review full report at Codecov.
|
bpoldrack
reviewed
Aug 17, 2021
As discussed in dataladgh-5808 the unconditional use can lead to problematic error reporting. @yarikoptic's verdict was to maintain the behavior, but limit it to data transfer commands. This change implements this move and enables this datalad-specific default only for `get` and `copy` operations. The latter is not implemented in `AnnexRepo.copy_to()` because this method is only used internally in tests, partially broken (dataladgh-5903), and was deprecated in Apr 2021. Instead, the change is implemented directly in `push`. Fixes datalad#5808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in gh-5808 the unconditional use can lead to problematic
error reporting. @yarikoptic's verdict was to maintain the behavior, but
limit it to data transfer commands.
This change implements this move and enables this datalad-specific
default only for
getandcopyoperations. The latter is notimplemented in
AnnexRepo.copy_to()because this method is only usedinternally in tests, partially broken (gh-5903), and was deprecated in
Apr 2021. Instead, the change is implemented directly in
push.Fixes #5808