Render siblings()'s non-ok results with the default renderer #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, siblings() would exclusively rely on result logging to communicate with a user. While this might have been enough a few years ago, it is now an outlier behavior. This change simply calls the default renderer for all results that the custom renderer cannot handle (and previously silently ignored). Fixes datalad#5147
yarikoptic
added
semver-patch
bpoldrack
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, siblings() would exclusively rely on result logging to
communicate with a user. While this might have been enough a few years
ago, it is now an outlier behavior.
This change simply calls the default renderer for all results that the
custom renderer cannot handle (and previously silently ignored).
Fixes #5147