Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render siblings()'s non-ok results with the default renderer #5915

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

mih
Copy link
Member

@mih mih commented Aug 18, 2021

Before this change, siblings() would exclusively rely on result logging to
communicate with a user. While this might have been enough a few years
ago, it is now an outlier behavior.

This change simply calls the default renderer for all results that the
custom renderer cannot handle (and previously silently ignored).

Fixes #5147

Before this change, siblings() would exclusively rely on result logging to
communicate with a user. While this might have been enough a few years
ago, it is now an outlier behavior.

This change simply calls the default renderer for all results that the
custom renderer cannot handle (and previously silently ignored).

Fixes datalad#5147
@mih mih linked an issue Aug 18, 2021 that may be closed by this pull request
@yarikoptic yarikoptic added semver-patch Increment the patch version when merged UX user experience labels Aug 18, 2021
@bpoldrack bpoldrack merged commit 1e0b00d into datalad:maint Aug 18, 2021
@mih mih deleted the bf-5147 branch August 26, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discontinue/enhance custom/tailored result renderer of siblings
3 participants