Skip to content

Add isort config to match current convention + run isort via pre-commit (if configured) #5923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 19, 2021

Closes #5922.

@jwodder jwodder added the semver-patch Increment the patch version when merged label Aug 19, 2021
@yarikoptic
Copy link
Member

awesome -- thank you @jwodder , I will test it out. I wonder -- why patch and not internal label?

@jwodder
Copy link
Member Author

jwodder commented Aug 19, 2021

@yarikoptic When I tried to add the "internal" label, it didn't come up. I may have made a typo.

@yarikoptic yarikoptic added semver-internal Changes only affect the internal API and removed semver-patch Increment the patch version when merged labels Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #5923 (380efc5) into maint (d1a19e2) will decrease coverage by 5.47%.
The diff coverage is n/a.

❗ Current head 380efc5 differs from pull request most recent head f1213ac. Consider uploading reports for the commit f1213ac to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5923      +/-   ##
==========================================
- Coverage   90.26%   84.78%   -5.48%     
==========================================
  Files         300      297       -3     
  Lines       42513    42477      -36     
==========================================
- Hits        38373    36014    -2359     
- Misses       4140     6463    +2323     
Impacted Files Coverage Δ
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
datalad/metadata/extractors/xmp.py 12.96% <0.00%> (-79.63%) ⬇️
datalad/metadata/extractors/exif.py 18.75% <0.00%> (-78.13%) ⬇️
datalad/metadata/extractors/image.py 19.35% <0.00%> (-77.42%) ⬇️
datalad/metadata/extractors/audio.py 20.00% <0.00%> (-77.15%) ⬇️
datalad/metadata/extractors/tests/test_exif.py 24.00% <0.00%> (-76.00%) ⬇️
datalad/metadata/extractors/tests/test_xmp.py 26.92% <0.00%> (-73.08%) ⬇️
datalad/metadata/extractors/tests/test_image.py 26.92% <0.00%> (-73.08%) ⬇️
datalad/cmdline/tests/test_helpers.py 38.18% <0.00%> (-61.82%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a19e2...f1213ac. Read the comment docs.

@yarikoptic
Copy link
Member

appveyor -- a Mac, As this change doesn't mandate anyone to anything, I will proceed with merge

@yarikoptic yarikoptic changed the title Run isort via pre-commit isort configuration to match current convention + run isort via pre-commit (if configured) Aug 20, 2021
@yarikoptic yarikoptic changed the title isort configuration to match current convention + run isort via pre-commit (if configured) Add isort config to match current convention + run isort via pre-commit (if configured) Aug 20, 2021
@yarikoptic yarikoptic merged commit dfdd352 into datalad:maint Aug 20, 2021
@jwodder jwodder deleted the gh-5922 branch October 12, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants