Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF?: add-archive-content on .xz and other non-.gz stream compressed files #5930

Merged
merged 3 commits into from Sep 10, 2021

Conversation

yarikoptic
Copy link
Member

If ever to be finished, closes #5929 . For now just establishes a test to demonstrate the failure (in future - test the fix).

May be it is not worth even attempting in maint but rather RF add-archive-content (it is one of the oldest, doesn't have --dataset argument etc) in master and likely drop going through the datalad-archives support code (and its caching mechanism), which only sees annex'ed keys at that level.

legacy .lzma support added just because it costs us nothing, and we might
encounter such archives and decide to add some fix/testing
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #5930 (eccaa31) into maint (dfdd352) will decrease coverage by 7.52%.
The diff coverage is 100.00%.

❗ Current head eccaa31 differs from pull request most recent head c70331b. Consider uploading reports for the commit c70331b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5930      +/-   ##
==========================================
- Coverage   90.28%   82.76%   -7.53%     
==========================================
  Files         300      297       -3     
  Lines       42516    42513       -3     
==========================================
- Hits        38387    35186    -3201     
- Misses       4129     7327    +3198     
Impacted Files Coverage Δ
datalad/interface/add_archive_content.py 89.85% <100.00%> (-0.24%) ⬇️
...atalad/interface/tests/test_add_archive_content.py 99.25% <100.00%> (-0.36%) ⬇️
datalad/tests/test_utils.py 88.34% <100.00%> (-8.13%) ⬇️
datalad/tests/utils.py 76.48% <100.00%> (-12.91%) ⬇️
datalad/utils.py 81.70% <100.00%> (-3.41%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
datalad/metadata/extractors/xmp.py 12.96% <0.00%> (-79.63%) ⬇️
datalad/metadata/extractors/exif.py 18.75% <0.00%> (-78.13%) ⬇️
datalad/metadata/extractors/image.py 19.35% <0.00%> (-77.42%) ⬇️
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdd352...c70331b. Read the comment docs.

… under annex key filename

adjusted to use absolute paths for .. imports and isorted them in the
add_archive_content.py while modifying them.  That discovered some
curious behavior of "import as" statements splitting import tuple while still
sorting alphabetically -- we might want to adjust configuration of isort for
that if possible if we decide that it should look differently
@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Aug 26, 2021
@yarikoptic yarikoptic marked this pull request as ready for review August 26, 2021 14:48
@yarikoptic yarikoptic added the merge-if-ok OP considers this work done, and requests review/merge label Aug 26, 2021
@yarikoptic yarikoptic added this to the 0.14.8 milestone Sep 9, 2021
@adswa
Copy link
Member

adswa commented Sep 9, 2021

I tried it, and it works for me

@yarikoptic
Copy link
Member Author

works for adina, works for me, what could go wrong? ;) let's proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants