BF?: add-archive-content on .xz and other non-.gz stream compressed files#5930
Merged
Conversation
legacy .lzma support added just because it costs us nothing, and we might encounter such archives and decide to add some fix/testing
Codecov Report
@@ Coverage Diff @@
## maint #5930 +/- ##
==========================================
- Coverage 90.28% 82.76% -7.53%
==========================================
Files 300 297 -3
Lines 42516 42513 -3
==========================================
- Hits 38387 35186 -3201
- Misses 4129 7327 +3198
Continue to review full report at Codecov.
|
… under annex key filename adjusted to use absolute paths for .. imports and isorted them in the add_archive_content.py while modifying them. That discovered some curious behavior of "import as" statements splitting import tuple while still sorting alphabetically -- we might want to adjust configuration of isort for that if possible if we decide that it should look differently
yarikoptic
added
the
merge-if-ok
Member
|
I tried it, and it works for me |
Member
Author
|
works for adina, works for me, what could go wrong? ;) let's proceed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ever to be finished, closes #5929 . For now just establishes a test to demonstrate the failure (in future - test the fix).
May be it is not worth even attempting in
maintbut rather RF add-archive-content (it is one of the oldest, doesn't have--datasetargument etc) inmasterand likely drop going through the datalad-archives support code (and its caching mechanism), which only sees annex'ed keys at that level.