-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: do use OBSCURE_FILENAME instead of hardcoded unicode #5944
Conversation
OBSCURE_UNICODE should be used since otherwise tests would just keep crashing while running on file systems/environment which do not support those fancy characters. Initial intention here was to address some Windows fails on Vista and other elderly systems. datalad#2929 If tests pass on current CI I would assume that we are past that stone age. Closes a part of datalad#5942. Wanted first to see if there are side-effects
Codecov Report
@@ Coverage Diff @@
## maint #5944 +/- ##
==========================================
- Coverage 90.28% 83.72% -6.57%
==========================================
Files 300 297 -3
Lines 42516 41375 -1141
==========================================
- Hits 38387 34642 -3745
- Misses 4129 6733 +2604
Continue to review full report at Codecov.
|
besides codecov all green, good, so I assume that appveyor is our gold standard for minimal version of windows to be compatible and will proceed fixing other similar failures in the same fashion. |
isort along the way
Windows doesn't like my questionable fix
|
3e30dde
to
596220b
Compare
596220b
to
0ceb5ff
Compare
Extracted a more "core" change to #5961 so this PR now concerns only with tests. |
I can't spot anything wrong with this PR, looks sensible to my not-so-expert eyes :) |
Thank you @adswa for feedback on all PRs staged for the release. Let's cut out the release by merging this PR, adding the label |
releasing failed (#5972 ), taking off the label since we might just want to retry |
OBSCURE_UNICODE should be used since otherwise tests would
just keep crashing while running on file systems/environment
which do not support those fancy characters.
Initial intention here was to address some Windows fails on Vista and
other elderly systems. #2929
If tests pass on current CI I would assume that we are past that
stone age.
Closes a part of #5942.
Wanted first to see if there are side-effects