-
Notifications
You must be signed in to change notification settings - Fork 118
BF: limit CMD_MAX_ARG if obnoxious value is encountered. #5945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apparently the issue observed with elderly python 3.4 (no longer supported) on Debian system, is likely to do nothing with the Python but some peculiarity of the system since now was observed on CentOS conda env with Python 3.9. Since our hardcoded limits are quite generous, and 3.4 is no longer support anyways, I decided just to add "flexible" check that if returned value is a million times larger (still have a buffer of thousand times in this particular case) -- take hardcoded value. Closes datalad#5943
Codecov Report
@@ Coverage Diff @@
## maint #5945 +/- ##
==========================================
- Coverage 90.28% 84.65% -5.64%
==========================================
Files 300 297 -3
Lines 42516 42480 -36
==========================================
- Hits 38387 35961 -2426
- Misses 4129 6519 +2390
Continue to review full report at Codecov.
|
|
appveyor -- mac not even bothering to start travis which is #4496 . |
|
Will merge tomorrow of no objections |
mih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be safe ;-)
|
travis -- AFAIK known NFS failing test, appveyor -- regular OSX fiasco. Let's proceed |
Apparently the issue observed with elderly python 3.4 (no longer
supported) on Debian system, is likely to do nothing with the
Python but some peculiarity of the system since now was observed on
CentOS conda env with Python 3.9.
Since our hardcoded limits are quite generous, and 3.4 is no longer
support anyways, I decided just to add "flexible" check that if
returned value is a million times larger (still have a buffer of
thousand times in this particular case) -- take hardcoded value.
Closes #5943