Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate datalad_core as not needing actual data -- just uses annex whereis #5971

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #5971 (3166a51) into maint (6f551f4) will decrease coverage by 5.34%.
The diff coverage is 100.00%.

❗ Current head 3166a51 differs from pull request most recent head 56d0731. Consider uploading reports for the commit 56d0731 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5971      +/-   ##
==========================================
- Coverage   90.30%   84.95%   -5.35%     
==========================================
  Files         300      297       -3     
  Lines       42516    42499      -17     
==========================================
- Hits        38392    36104    -2288     
- Misses       4124     6395    +2271     
Impacted Files Coverage Δ
datalad/metadata/extractors/datalad_core.py 89.58% <100.00%> (+0.22%) ⬆️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/extractors/tests/test_audio.py 19.35% <0.00%> (-80.65%) ⬇️
datalad/metadata/extractors/xmp.py 12.96% <0.00%> (-79.63%) ⬇️
datalad/metadata/extractors/exif.py 18.75% <0.00%> (-78.13%) ⬇️
datalad/metadata/extractors/image.py 19.35% <0.00%> (-77.42%) ⬇️
datalad/metadata/extractors/audio.py 20.00% <0.00%> (-77.15%) ⬇️
datalad/metadata/extractors/tests/test_exif.py 24.00% <0.00%> (-76.00%) ⬇️
datalad/metadata/extractors/tests/test_xmp.py 26.92% <0.00%> (-73.08%) ⬇️
datalad/metadata/extractors/tests/test_image.py 26.92% <0.00%> (-73.08%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f551f4...56d0731. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit 11a34d8 into datalad:maint Sep 9, 2021
@yarikoptic yarikoptic deleted the bf-datalad-core-no-need-for-data branch October 8, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants