Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --pbs-runner cmdline option #5981

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Sep 15, 2021

Was deprecated with the 0.15.0 release, see gh-5956.

Fixes #5962

Was deprecated with the 0.15.0 release, see dataladgh-5956.

Fixes datalad#5962
@mih mih added the semver-minor Increment the minor version when merged label Sep 15, 2021
@mih mih added this to the 0.16.0 milestone Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #5981 (da779e5) into master (1e0f732) will decrease coverage by 55.46%.
The diff coverage is 100.00%.

❗ Current head da779e5 differs from pull request most recent head f426b8f. Consider uploading reports for the commit f426b8f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5981       +/-   ##
===========================================
- Coverage   90.32%   34.85%   -55.47%     
===========================================
  Files         308      305        -3     
  Lines       42111    42054       -57     
===========================================
- Hits        38035    14660    -23375     
- Misses       4076    27394    +23318     
Impacted Files Coverage Δ
datalad/cmdline/common_args.py 100.00% <ø> (ø)
datalad/cmdline/helpers.py 38.16% <ø> (-33.65%) ⬇️
datalad/interface/base.py 82.75% <ø> (-7.48%) ⬇️
datalad/cmdline/main.py 61.46% <100.00%> (-14.85%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_api.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/digests.py 0.00% <0.00%> (-100.00%) ⬇️
... and 266 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0f732...f426b8f. Read the comment docs.

Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yarikoptic
Copy link
Member

Thank you but:
I guess it is great to have those PRs so we do not "forget" to remove deprecated clutter, but since they would be just hanging here cluttering the list of PRs. If we establish next branch -- we could merge them there but then we would need to deal with conflicts etc... But also I thought we agreed on that removal of deprecated functionality should happen more on "time" than on "release" basis to provide users enough time. We don't know when we would release 0.16.0 .

@mih
Copy link
Member Author

mih commented Sep 15, 2021

My intention was to have to merged now-ish. This is positioned against master. The next release coined from master will be 0.16.0. And with what I learned from the 0.15.0 release actually no release will ever come from master.

Are you saying that there should be a minimum time after a release for changes in master scheduled for the next non-maint release? If so, what would be the delay?

Moreover, given that deprecations are not visible enough, would it not call for removals to happen at the earliest time in a release cycle to actually catch breakages during development, rather than post-release?

@yarikoptic
Copy link
Member

sorry, I was slow -- right, it will then go to 0.16.0 . all good indeed!

@mih mih merged commit b0f00c2 into datalad:master Sep 16, 2021
@mih mih deleted the rf-pbsrunner branch September 16, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated --pbs-runner option
3 participants