Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(TST): use sys.executable, mark test_ria_basics.test_url_keys as requiring network #5986

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Sep 15, 2021

Detected while building Debian package .

Also did isort on those tests files

Detected while building Debian package .

Also did isort on that tests file
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #5986 (0fd2e73) into maint (1e0f732) will decrease coverage by 1.84%.
The diff coverage is 100.00%.

❗ Current head 0fd2e73 differs from pull request most recent head c3b4525. Consider uploading reports for the commit c3b4525 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5986      +/-   ##
==========================================
- Coverage   90.32%   88.48%   -1.85%     
==========================================
  Files         308      305       -3     
  Lines       42111    42095      -16     
==========================================
- Hits        38035    37246     -789     
- Misses       4076     4849     +773     
Impacted Files Coverage Δ
datalad/distributed/tests/test_ria_basics.py 97.56% <100.00%> (-0.30%) ⬇️
datalad/tests/test_nonasyncrunner.py 100.00% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0f732...c3b4525. Read the comment docs.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Sep 15, 2021
@yarikoptic yarikoptic added this to the 0.15.1 milestone Sep 15, 2021
@yarikoptic yarikoptic changed the title BF: use sys.executable, not hardcoded "python" BF(TST): use sys.executable, mark test_ria_basics.test_url_keys as requiring network Sep 15, 2021
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit 6d4b36c into datalad:maint Sep 16, 2021
@yarikoptic yarikoptic deleted the bf-python branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants