Large code-reorganization of everything runner-related #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the core exception type used, and it is only raised by the runner (except for test code). Reimport to its previous place to avoid breakage.
Not needed elsewhere, but re-import to avoid breakage.
The non-runner execution (BatchedCommand) is put back in its original place, where it was before this RF.
These (alone) give ``` Name Stmts Miss Cover Missing ---------------------------------------------------------------- datalad/runner/__init__.py 4 0 100% datalad/runner/coreprotocols.py 19 2 89% 53-54 datalad/runner/exception.py 38 6 84% 56, 59-63, 67, 70 datalad/runner/gitrunner.py 72 13 82% 51-55, 68, 87, 94-96, 186, 197-198 datalad/runner/nonasyncrunner.py 96 1 99% 111 datalad/runner/protocol.py 57 3 95% 74, 89-93 datalad/runner/runner.py 36 0 100% datalad/runner/utils.py 3 0 100% ---------------------------------------------------------------- TOTAL 325 25 92% ---------------------------------------------------------------------- Ran 21 tests in 9.602s ```
Codecov Report
@@ Coverage Diff @@
## maint #6008 +/- ##
==========================================
- Coverage 90.28% 88.48% -1.80%
==========================================
Files 308 312 +4
Lines 42103 42131 +28
==========================================
- Hits 38012 37281 -731
- Misses 4091 4850 +759
Continue to review full report at Codecov.
|
Use relative imports for runner components using the symbols from datalad.runner Split off cmd.py test code into a separate module.
|
crawler failure is same old datalad/datalad-crawler#104 |
bpoldrack
reviewed
Sep 27, 2021
christian-monch
approved these changes
Sep 27, 2021
|
Thanks for the feedback, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this re-organizes the code to establish
datalad.runneras a self-contained subpackage that include all runner-related functionality, and no other functionality. Legacy imports are put in place to minimize likelihood of API breakage.CommandErrorwith the runner code, as they are tightly linkedThis is proposed against
maintto avoid carrying a large diff for the full 0.16 release cycle. it should cause no breakage.