Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize usage of --dry-run vs --dryrun in create-sibling-gitlab #6013

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Harmonize usage of --dry-run vs --dryrun in create-sibling-gitlab #6013

merged 2 commits into from
Oct 1, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Sep 27, 2021

This adds a --dry-run parameter to create-sibling-gitlab to match the corresponding parameter in create-sibling-{github,gin,gogs,gitea}, and deprecates the current --dryrun option.
The PR also includes a small doc fix to the URL pointing to the documentation of python gitlab

@codecov
Copy link

codecov bot commented Sep 27, 2021 •
edited
Loading

Codecov Report

Merging #6013 (ffcd469) into master (a43d41a) will decrease coverage by 25.11%.
The diff coverage is 80.00%.

❗ Current head ffcd469 differs from pull request most recent head 531618d. Consider uploading reports for the commit 531618d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6013       +/-   ##
===========================================
- Coverage   90.16%   65.05%   -25.12%     
===========================================
  Files         315      312        -3     
  Lines       42196    42165       -31     
===========================================
- Hits        38047    27429    -10618     
- Misses       4149    14736    +10587
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gitlab.py 74.37% <60.00%> (-0.63%) ⬇️
...ad/distributed/tests/test_create_sibling_gitlab.py 100.00% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43d41a...531618d. Read the comment docs.

@yarikoptic
Copy link
Member

+1 on harmonizing into --dry-run (instead of --dryrun)

mih
mih requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thx!

It would be good to discontinue the use of dryrun in the tests, though.

datalad/distributed/create_sibling_gitlab.py Outdated Show resolved Hide resolved
@adswa
RF/UX: Harmonize usage of --dry-run vs --dryrun in create-sibling-gitlab
d262185 
PR datalad#5949 deprecated the parameter --dryrun in favor of --dry-run in create-sibling{github,gogs,gitea,gin}.
This change fixes datalad#6011 by adding this deprecation and parameter alternative to create-sibling-gitlab as
well, in order to harmonize the usage of this parameter across the family of create-sibling-* commands.

TST: Discontinue use of deprecated dryrun in tests
@adswa
DOC: Fix link to the GitLab configuration documentatoin of Python GitLab
531618d
@adswa
Copy link
Member Author

adswa commented Sep 28, 2021

It would be good to discontinue the use of dryrun in the tests, though.

Right, thanks much for catching this. I have replaced them, and force-pushed.

@adswa adswa added the semver-patch Increment the patch version when merged label Sep 28, 2021
@adswa adswa linked an issue Sep 28, 2021 that may be closed by this pull request
--dryrun of create-sibling-gitlab not yet deprecated in favor of dry-run #6011
Closed
@adswa
Copy link
Member Author

adswa commented Sep 29, 2021

The Appveyor failure is a network glitch, I think

Error making request with Error Code NotFound and Http Status Code NotFound. No further error information was returned by the service.

mih
mih approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@mih mih merged commit 8480478 into datalad:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mih mih mih approved these changes

Assignees
No one assigned
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--dryrun of create-sibling-gitlab not yet deprecated in favor of dry-run
3 participants
@adswa @yarikoptic @mih