Skip to content

UX: Report GitLab weburl of freshly created projects in the result#6017

Merged
adswa merged 2 commits intodatalad:maintfrom
adswa:ux-6016
Sep 28, 2021
Merged

UX: Report GitLab weburl of freshly created projects in the result#6017
adswa merged 2 commits intodatalad:maintfrom
adswa:ux-6016

Conversation

@adswa
Copy link
Member

@adswa adswa commented Sep 27, 2021

This harmonizes the reporting of create-sibling-gitlab and the
create-sibling-ghlike-commands slightly more, and fixes #6016.

Here is how it looks with the change:

(handbook2) adina@muninn in ~/repos/datalad on git:ux-6016
$ datalad create-sibling-gitlab  -d . --site jugit --project datalad3 --layout flat --access ssh         
create_sibling_gitlab(ok): . (dataset) [sibling repository 'jugit' created at https://jugit.fz-juelich.de/adswa/datalad3]
configure-sibling(ok): . (sibling)
action summary:
  configure-sibling (ok: 1)
  create_sibling_gitlab (ok: 1)

which is closer to what I get when using create-sibling-github:

$ datalad create-sibling-github new-create-sibling-command-gh4                 
create_sibling_github(ok): [sibling repository 'github' created at https://github.com/adswa/new-create-sibling-command-gh4]
configure-sibling(ok): . (sibling)
action summary:
  configure-sibling (ok: 1)
  create_sibling_github (ok: 1)

This harmonizes the reporting of create-sibling-gitlab and the
create-sibling-ghlike-commands slightly more, and fixes datalad#6016.
@adswa adswa changed the base branch from master to maint September 27, 2021 13:22
@adswa
Copy link
Member Author

adswa commented Sep 27, 2021

mhh, something is wrong with the unit tests (they did not start). Pushing an empty commit to trigger them

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #6017 (10102d7) into maint (d183fd7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6017      +/-   ##
==========================================
+ Coverage   90.28%   90.30%   +0.01%     
==========================================
  Files         315      315              
  Lines       42149    42269     +120     
==========================================
+ Hits        38056    38169     +113     
- Misses       4093     4100       +7     
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gitlab.py 75.00% <100.00%> (+0.16%) ⬆️
datalad/downloaders/tests/test_http.py 89.17% <0.00%> (-1.89%) ⬇️
datalad/interface/tests/test_base.py 98.48% <0.00%> (-0.66%) ⬇️
datalad/utils.py 85.04% <0.00%> (+0.09%) ⬆️
datalad/distributed/tests/test_ria_basics.py 97.86% <0.00%> (+0.30%) ⬆️
datalad/distributed/ora_remote.py 31.74% <0.00%> (+0.32%) ⬆️
datalad/interface/base.py 92.01% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d183fd7...10102d7. Read the comment docs.

@mih mih added the semver-patch Increment the patch version when merged label Sep 28, 2021
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@adswa adswa merged commit 1577868 into datalad:maint Sep 28, 2021
@adswa adswa deleted the ux-6016 branch September 28, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: create-sibling-gitlab should report the URL of created GitLab projects

2 participants