Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: start global test_http_server only if not running already #6023

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Sep 29, 2021

This fix seems to resolve the stall for conda builds in a docker container.

Closes #5992 (well -- final verdict is yet to be made, but it seems to resolve on local builds yeap -- that fixed it -- all green in conda-forge/datalad-feedstock#63, merged)

This fix seems to resolve the stall for conda builds in a docker container.

Closes datalad#5992
@yarikoptic yarikoptic added this to the 0.15.2 milestone Sep 29, 2021
@yarikoptic yarikoptic added the tests Add or improve existing tests label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #6023 (6cfa6c8) into maint (d183fd7) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##            maint    #6023   +/-   ##
=======================================
  Coverage   90.28%   90.29%           
=======================================
  Files         315      315           
  Lines       42149    42166   +17     
=======================================
+ Hits        38056    38075   +19     
+ Misses       4093     4091    -2     
Impacted Files Coverage Δ
datalad/__init__.py 86.58% <85.71%> (-0.38%) ⬇️
datalad/interface/tests/test_base.py 98.36% <0.00%> (-0.78%) ⬇️
datalad/tests/test_log.py 99.30% <0.00%> (+<0.01%) ⬆️
datalad/interface/base.py 90.28% <0.00%> (+0.05%) ⬆️
datalad/utils.py 85.04% <0.00%> (+0.09%) ⬆️
datalad/distributed/create_sibling_gitlab.py 75.00% <0.00%> (+0.16%) ⬆️
datalad/log.py 88.04% <0.00%> (+0.19%) ⬆️
datalad/distributed/tests/test_ria_basics.py 97.86% <0.00%> (+0.30%) ⬆️
datalad/distributed/ora_remote.py 31.74% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d183fd7...6cfa6c8. Read the comment docs.

@yarikoptic yarikoptic added the merge-if-ok OP considers this work done, and requests review/merge label Sep 29, 2021
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense! Thanks for digging it out!

@mih mih merged commit 53183e3 into datalad:maint Oct 1, 2021
@yarikoptic yarikoptic deleted the bf-global-http-server branch October 8, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants