Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: disable outdated SSL root certificate breaking chain on older/buggy clients #6027

Merged
merged 1 commit into from Oct 3, 2021

Conversation

yarikoptic
Copy link
Member

Closes #6026

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #6027 (3f2701a) into maint (d183fd7) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6027      +/-   ##
==========================================
- Coverage   90.28%   90.27%   -0.02%     
==========================================
  Files         315      315              
  Lines       42149    42166      +17     
==========================================
+ Hits        38056    38067      +11     
- Misses       4093     4099       +6     
Impacted Files Coverage Δ
datalad/downloaders/tests/test_http.py 89.17% <0.00%> (-1.89%) ⬇️
datalad/interface/tests/test_base.py 98.36% <0.00%> (-0.78%) ⬇️
datalad/__init__.py 86.58% <0.00%> (-0.38%) ⬇️
datalad/tests/test_log.py 99.30% <0.00%> (+<0.01%) ⬆️
datalad/interface/base.py 90.28% <0.00%> (+0.05%) ⬆️
datalad/utils.py 85.04% <0.00%> (+0.09%) ⬆️
datalad/distributed/create_sibling_gitlab.py 75.00% <0.00%> (+0.16%) ⬆️
datalad/log.py 88.04% <0.00%> (+0.19%) ⬆️
datalad/distributed/tests/test_ria_basics.py 97.86% <0.00%> (+0.30%) ⬆️
datalad/distributed/ora_remote.py 31.74% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d183fd7...3f2701a. Read the comment docs.

@yarikoptic yarikoptic added the merge-if-ok OP considers this work done, and requests review/merge label Oct 2, 2021
@yarikoptic
Copy link
Member Author

since all green CIs, I would assume that it is indeed fixing a possible issue, so will proceed with merge, we can always revert ;)

@yarikoptic yarikoptic merged commit 6ae9dd8 into datalad:maint Oct 3, 2021
@yarikoptic
Copy link
Member Author

FTR: merged maint into master and pushed (there were only two PRs merged, both BFs)

@yarikoptic yarikoptic deleted the bf-ssl branch October 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant