Skip to content

Discontinue usage of deprecated (public) helper#6032

Merged
mih merged 1 commit intodatalad:maintfrom
mih:bf-6030
Oct 5, 2021
Merged

Discontinue usage of deprecated (public) helper#6032
mih merged 1 commit intodatalad:maintfrom
mih:bf-6030

Conversation

@mih
Copy link
Copy Markdown
Member

@mih mih commented Oct 5, 2021

Fixes #6030

This is an alternative to #6031 which maintains the general direction, while avoiding the complications.

@mih mih linked an issue Oct 5, 2021 that may be closed by this pull request
@mih mih added the semver-patch Increment the patch version when merged label Oct 5, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2021

Codecov Report

Merging #6032 (1896a34) into maint (53183e3) will decrease coverage by 1.70%.
The diff coverage is 100.00%.

❗ Current head 1896a34 differs from pull request most recent head 066e3af. Consider uploading reports for the commit 066e3af to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6032      +/-   ##
==========================================
- Coverage   90.19%   88.48%   -1.71%     
==========================================
  Files         315      312       -3     
  Lines       42165    42152      -13     
==========================================
- Hits        38030    37300     -730     
- Misses       4135     4852     +717     
Impacted Files Coverage Δ
datalad/cmd.py 85.27% <100.00%> (-5.28%) ⬇️
datalad/tests/test_installed.py 90.00% <100.00%> (+1.11%) ⬆️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53183e3...066e3af. Read the comment docs.

@mih mih added the merge-if-ok OP considers this work done, and requests review/merge label Oct 5, 2021
@mih mih merged commit ba32ae2 into datalad:maint Oct 5, 2021
@mih mih deleted the bf-6030 branch October 5, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-if-ok OP considers this work done, and requests review/merge semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readline_rstripped() should be un-deprecated

2 participants