Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor datalad.runtime.use-patool if set regardless of OS (was Windows only) #6033

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

mih
Copy link
Member

@mih mih commented Oct 5, 2021

Previously, windows was a declared special case in which the flag was
effectively ignored. This is confusing, and may be unjustified even.

Fixes #5044

Previously, windows was a declared special case in which the flag was
effectively ignored. This is confusing, and may be unjustified even.

Fixes datalad#5044
@mih mih added the semver-patch Increment the patch version when merged label Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #6033 (68c086d) into maint (53183e3) will decrease coverage by 2.92%.
The diff coverage is 100.00%.

❗ Current head 68c086d differs from pull request most recent head 9cf12ed. Consider uploading reports for the commit 9cf12ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #6033      +/-   ##
==========================================
- Coverage   90.19%   87.26%   -2.93%     
==========================================
  Files         315      312       -3     
  Lines       42165    41037    -1128     
==========================================
- Hits        38030    35812    -2218     
- Misses       4135     5225    +1090     
Impacted Files Coverage Δ
datalad/support/archives.py 86.06% <100.00%> (-0.28%) ⬇️
datalad/tests/test_installed.py 89.47% <100.00%> (+0.58%) ⬆️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_archive.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/export_to_figshare.py 0.00% <0.00%> (-100.00%) ⬇️
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53183e3...9cf12ed. Read the comment docs.

@mih mih added the merge-if-ok OP considers this work done, and requests review/merge label Oct 5, 2021
@yarikoptic
Copy link
Member

and let's push a release with this simple one, we are already at 0.15.1-33-gba32ae216

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 5, 2021
@yarikoptic yarikoptic changed the title Honor datalad.runtime.use-patool if set Honor datalad.runtime.use-patool if set regardless of OS (was Windows only) Oct 5, 2021
@yarikoptic yarikoptic merged commit 14398d7 into datalad:maint Oct 5, 2021
@yarikoptic yarikoptic added this to the 0.15.2 milestone Oct 5, 2021
@mih mih deleted the bf-5044 branch October 5, 2021 15:25
@yarikoptic
Copy link
Member

hm, I do not see github actions for release to ever trigger after merging this PR: https://github.com/datalad/datalad/actions/workflows/release.yml so it was not released. @jwodder -- any clue on what have might happened?
meanwhile I guess I will remove release label from this PR and we could apply it to some other PR to see if release action would finally kick in

@yarikoptic yarikoptic removed the release Create a release when this pr is merged label Oct 6, 2021
@jwodder
Copy link
Member

jwodder commented Oct 6, 2021

@yarikoptic GitHub Actions was having some problems yesterday; I experienced a run for datalad/git-annex that waited forever and never started.

@yarikoptic
Copy link
Member

ah, odd ... I was told that yesterday for some reason many services (not just github) were experiencing issues. I wonder what was the "Common denominator" ;) cool, so let's just try with some other PR merge to maint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misleading suggestion in the error message - datalad.runtime.use-patool is in fact ignored on windows
3 participants