Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ux get result handling broken #6052

Merged
merged 3 commits into from Oct 9, 2021

Conversation

christian-monch
Copy link
Contributor

Fixes issue #5940. Adds a guard for "path"-lookups in result dictionaries. Adds regression tests.

[x] adds a guard for "path"-lookups in result dictionary handling in get
[x] asserts that "ok"-results have a "path"-key
[x] adds regression tests

@christian-monch christian-monch added tests Add or improve existing tests UX user experience labels Oct 7, 2021
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for looking into this! I left a concern

datalad/distribution/get.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #6052 (48dbc97) into maint (662b0a5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            maint    #6052   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files         312      312           
  Lines       42189    42206   +17     
=======================================
+ Hits        38080    38097   +17     
  Misses       4109     4109           
Impacted Files Coverage Δ
datalad/distribution/get.py 97.90% <100.00%> (ø)
datalad/distribution/tests/test_get.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662b0a5...48dbc97. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit d303782 into datalad:maint Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants