Ux get result handling broken#6052
Merged
Merged
Conversation
mih
requested changes
Oct 7, 2021
Member
mih
left a comment
mih
left a comment
There was a problem hiding this comment.
Thx for looking into this! I left a concern
Codecov Report
@@ Coverage Diff @@
## maint #6052 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 312 312
Lines 42189 42206 +17
=======================================
+ Hits 38080 38097 +17
Misses 4109 4109
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #5940. Adds a guard for "path"-lookups in result dictionaries. Adds regression tests.
[x] adds a guard for "path"-lookups in result dictionary handling in get
[x] asserts that "ok"-results have a "path"-key
[x] adds regression tests