BF: do not leave test in a tmp dir destined for removal #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwite it does trigger assert_no_open_files since if it is wrapping around @with_tempfile -- that one cannot rmdir it since it is open (we have it as a CWD)
Codecov Report
@@ Coverage Diff @@
## maint #6059 +/- ##
==========================================
- Coverage 90.26% 90.25% -0.01%
==========================================
Files 312 312
Lines 42189 42189
==========================================
- Hits 38080 38077 -3
- Misses 4109 4112 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Othervice it does trigger assert_no_open_files since if it is wrapping around
@with_tempfile-- that one cannot rmdir it since it is open (we have it as a CWD)