BF: archives upon strip - use rmtree which retries etc instead of rmdir#6064
Merged
mih merged 1 commit intodatalad:maintfrom Oct 9, 2021
Merged
BF: archives upon strip - use rmtree which retries etc instead of rmdir#6064mih merged 1 commit intodatalad:maintfrom
mih merged 1 commit intodatalad:maintfrom
Conversation
possible side-effect - if code logic would be flawed and leave some files behind, rmtree would remove them as well (whenever rmdir would fail). But since tested and never crashed before for that reason I think it should be safe. I have tried to troubleshoot/figure out exact problem with datalad#6058 but it did not reproduce, so decided to just make code robust
5 tasks
Codecov Report
@@ Coverage Diff @@
## maint #6064 +/- ##
===========================================
- Coverage 90.26% 35.19% -55.07%
===========================================
Files 312 312
Lines 42189 42171 -18
===========================================
- Hits 38080 14842 -23238
- Misses 4109 27329 +23220
Continue to review full report at Codecov.
|
yarikoptic
added
the
merge-if-ok
mih
approved these changes
Oct 9, 2021
Member
mih
left a comment
mih
left a comment
There was a problem hiding this comment.
Feels a bit hacky, but I can follow your reasoning. Should not be worse than what it was, and has the potential to help in some cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possible side-effect - if code logic would be flawed and leave some files
behind, rmtree would remove them as well (whenever rmdir would fail).
But since tested and never crashed before for that reason I think it should be
safe.
I have tried to troubleshoot/figure out exact problem with
#6058
but it did not reproduce, so decided to just make code robust
edit: the hope is that it closes #4496