Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Travis tests on deprecation warnings #6074

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 13, 2021

@jwodder jwodder added the tests Add or improve existing tests label Oct 13, 2021
@jwodder jwodder changed the base branch from master to maint October 13, 2021 18:21
@jwodder jwodder changed the title Fail on deprecations Fail Travis tests on deprecation warnings Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #6074 (3ec47bb) into maint (62a8987) will decrease coverage by 32.72%.
The diff coverage is 43.00%.

❗ Current head 3ec47bb differs from pull request most recent head 22ba985. Consider uploading reports for the commit 22ba985 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            maint    #6074       +/-   ##
===========================================
- Coverage   90.24%   57.51%   -32.73%     
===========================================
  Files         312      312               
  Lines       42215    42473      +258     
===========================================
- Hits        38096    24429    -13667     
- Misses       4119    18044    +13925     
Impacted Files Coverage Δ
datalad/cmdline/common_args.py 100.00% <ø> (ø)
datalad/cmdline/helpers.py 71.09% <0.00%> (ø)
datalad/core/distributed/tests/test_push.py 80.04% <ø> (-18.90%) ⬇️
...ad/distributed/tests/test_create_sibling_gitlab.py 0.00% <0.00%> (-100.00%) ⬇️
...talad/distributed/tests/test_create_sibling_ria.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distributed/tests/test_ria.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distributed/tests/test_ria_basics.py 0.00% <ø> (-97.57%) ⬇️
datalad/interface/__init__.py 100.00% <ø> (ø)
datalad/interface/base.py 90.00% <ø> (-0.29%) ⬇️
datalad/local/tests/test_subdataset.py 0.00% <0.00%> (-100.00%) ⬇️
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a8987...22ba985. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

I filed #6079, I don't see why this should be travis-only.

@mih mih merged commit 3269925 into datalad:maint Oct 15, 2021
@jwodder jwodder deleted the fail-on-deprecations branch May 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants