Replace AnnotatePaths in metadata commands #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the second-to-last stop to finally fix datalad#3368 There is only a minimal behavior change: A rather peculiar reporting behavior, where metadata of the "nearest" available dataset is chosen when no explicit dataset is given. This has no practical value and would complicate this temporary fix substantially. This whole stuff only needs to last until metalad is fully functional.
bpoldrack
approved these changes
Oct 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #6128 +/- ##
==========================================
- Coverage 89.82% 88.89% -0.93%
==========================================
Files 317 317
Lines 42399 42397 -2
==========================================
- Hits 38083 37689 -394
- Misses 4316 4708 +392
Continue to review full report at Codecov.
|
|
Thanks @bpoldrack Will merge tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second-to-last stop to finally resolve #3368
There is only a minimal behavior change: A rather peculiar reporting
behavior, where metadata of the "nearest" available dataset is chosen
when no explicit dataset is given.
This has no practical value and would complicate this temporary fix
substantially. This whole stuff only needs to last until metalad is
fully functional.