Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Enable more Windows tests #6136

Merged
merged 2 commits into from
Nov 5, 2021
Merged

TST: Enable more Windows tests #6136

merged 2 commits into from
Nov 5, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 3, 2021

A mix of newly enabled tests because they passed on an actual Windows box, and a few adjusted tests that pass after they got a Window equivalent to a Unix command. Let's see if the CIs agree.

@adswa adswa added the semver-internal Changes only affect the internal API label Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #6136 (aa745f1) into master (5adfde7) will decrease coverage by 0.76%.
The diff coverage is 97.14%.

❗ Current head aa745f1 differs from pull request most recent head 6b0cc8d. Consider uploading reports for the commit 6b0cc8d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6136      +/-   ##
==========================================
- Coverage   89.73%   88.97%   -0.77%     
==========================================
  Files         317      317              
  Lines       42394    42397       +3     
==========================================
- Hits        38042    37722     -320     
- Misses       4352     4675     +323     
Impacted Files Coverage Δ
datalad/core/local/create.py 97.05% <ø> (ø)
datalad/core/local/tests/test_create.py 100.00% <ø> (ø)
datalad/distribution/tests/test_install.py 100.00% <ø> (ø)
datalad/interface/tests/test_download_url.py 100.00% <ø> (ø)
datalad/support/tests/test_locking.py 91.66% <ø> (-0.09%) ⬇️
datalad/tests/test_utils_cached_dataset.py 100.00% <ø> (ø)
datalad/tests/utils.py 88.41% <ø> (-0.76%) ⬇️
datalad/distribution/create_sibling.py 66.17% <87.50%> (+0.30%) ⬆️
datalad/core/distributed/tests/test_clone.py 97.04% <100.00%> (-0.40%) ⬇️
datalad/distribution/get.py 97.93% <100.00%> (+<0.01%) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adfde7...6b0cc8d. Read the comment docs.

@adswa
Copy link
Member Author

adswa commented Nov 3, 2021

ha, they all passed 🎉

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thx!

@mih mih merged commit 11e4e20 into datalad:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants