Skip to content

BF: clone tried to save new subdataset despite failing to clone #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mih merged 1 commit into from
Nov 5, 2021
Merged

BF: clone tried to save new subdataset despite failing to clone #6140

mih merged 1 commit into from
Nov 5, 2021

Conversation

@bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Nov 4, 2021

Closes #6138

@bpoldrack bpoldrack added semver-minor Increment the minor version when merged semver-patch Increment the patch version when merged and removed semver-minor Increment the minor version when merged labels Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #6140 (f03d99f) into maint (5c4abae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            maint    #6140   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         312      312           
  Lines       42231    42244   +13     
=======================================
+ Hits        38106    38118   +12     
- Misses       4125     4126    +1
Impacted Files Coverage Δ
datalad/core/distributed/clone.py 90.94% <100.00%> (-0.11%) ⬇️
datalad/core/distributed/tests/test_clone.py 97.45% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4abae...f03d99f. Read the comment docs.

@adswa
Copy link
Member

adswa commented Nov 4, 2021

looks good to me

@yarikoptic yarikoptic mentioned this pull request Nov 4, 2021
Closed
mih
mih approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thx

@mih mih merged commit a00ab3a into datalad:maint Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mih mih mih approved these changes

Assignees

No one assigned

Labels

semver-patch Increment the patch version when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bpoldrack @adswa @mih