Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape backslashes in some regexes #6147

Merged
merged 1 commit into from Nov 5, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 5, 2021

Fixes #5985

@mih mih added the semver-patch Increment the patch version when merged label Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #6147 (d9fd85c) into master (3cbc5cd) will decrease coverage by 2.60%.
The diff coverage is 50.00%.

❗ Current head d9fd85c differs from pull request most recent head 36f3155. Consider uploading reports for the commit 36f3155 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6147      +/-   ##
==========================================
- Coverage   89.76%   87.16%   -2.61%     
==========================================
  Files         318      318              
  Lines       41855    41863       +8     
==========================================
- Hits        37571    36489    -1082     
- Misses       4284     5374    +1090     
Impacted Files Coverage Δ
datalad/tests/test_log.py 93.05% <50.00%> (-6.25%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/drop.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/remove.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbc5cd...36f3155. Read the comment docs.

@mih mih merged commit 54d1600 into datalad:master Nov 5, 2021
@mih mih deleted the bf-escapes branch November 11, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: invalid escape sequence used in tests
1 participant