Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF+BF: use skip_if_no_module helper instead of try/except for libxmp and boto #6148

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

yarikoptic
Copy link
Member

Closes #6141 ("maint" specific, "master" was catching all exceptions, conflicts will need to be resolved in favor of the helper)

…and boto

Closes datalad#6141 ("maint" specific, "master" was catching all exceptions)
@yarikoptic yarikoptic added the tests Add or improve existing tests label Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #6148 (50da3a5) into maint (5bbe9d1) will decrease coverage by 12.07%.
The diff coverage is 25.00%.

❗ Current head 50da3a5 differs from pull request most recent head 3edaa6d. Consider uploading reports for the commit 3edaa6d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            maint    #6148       +/-   ##
===========================================
- Coverage   90.19%   78.12%   -12.08%     
===========================================
  Files         312      312               
  Lines       42249    42217       -32     
===========================================
- Hits        38108    32981     -5127     
- Misses       4141     9236     +5095     
Impacted Files Coverage Δ
datalad/metadata/extractors/tests/test_xmp.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/metadata/tests/test_extract_metadata.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/downloaders/tests/test_s3.py 52.00% <100.00%> (+0.36%) ⬆️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbe9d1...3edaa6d. Read the comment docs.

@mih mih merged commit 0df06be into datalad:maint Nov 5, 2021
@yarikoptic yarikoptic deleted the bf-skip-no-xmp branch April 5, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants