New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: Provide custom prefix to auto-related labels #6151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6151 +/- ##
==========================================
- Coverage 90.21% 89.70% -0.51%
==========================================
Files 312 318 +6
Lines 42235 41854 -381
==========================================
- Hits 38104 37547 -557
- Misses 4131 4307 +176
Continue to review full report at Codecov.
|
I wonder on what disturbance that would cause interim since if we rename the labels and workflow in master -- |
I am all for such a change. I am totally unaware of what disturbances it would cause. But I do know that a release from |
With @mih's statement and @bpoldrack's thumbs up this kinda sounds like we could proceed here? AFAIK we could rename the current labels by editing them |
FWIW, on a 2nd thought, since upon rename -- would be worthwhile to check recently merged PRs if their labels were updated correspondingly. |
Sound like a plan! Thx! |
This change is an attempt to act on the suggestion in datalad#5833 to ease understanding in how PRs need to be labelled for the 'auto' versioning workflow. The test checking for appropriate labelling of PRs is called 'semver', hence my initial suggestion here in this change is a semver prefix in hopes to make the relevant issues more discoverable to new contributors.
I rebased to |
I had to re-attach the label to the PR to have it picked up by the semver test |
I killed the appveyor tests -- nothing in here is relevant for appveyor. |
OK, let's do it. |
In looking through the issues closed over the weekend, I felt compelled to act on the suggestion in #5833 to prefix a common, versioning-related identifier to the PR labels for the auto-workflow.
I think there was some general agreement in the original issue, but not enough momentum to implement the change. I personally keep forgetting which labels exist, and would be in favor of having them in one group to ease discoverability.
I'm suggesting
semver
as a prefix, because the corresponding test is called "Test for semver label". I'm happy to change this into anything else, though.