Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design document on result records #6167

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Design document on result records #6167

merged 1 commit into from
Nov 11, 2021

Conversation

mih
Copy link
Member

@mih mih commented Nov 10, 2021

Developers are encouraged to amend this initial document with additional information, in particular field names that are in active use.

Please suggest concrete changes/addition using the reviewing functionality of by pushing the this branch. Given the documentation-nature of this PR, I will merge this tomorrow, unless objections are expressed.

@adswa
Copy link
Member

adswa commented Nov 10, 2021

I find this very helpful! Left a few comments

Developers are encouraged to amend this initial document
with additional information, in particular field names
that are in active use.

Fixes datalad#6054
Fixes datalad#6171

[skip ci]
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #6167 (9c4c1c8) into master (981aa95) will decrease coverage by 2.05%.
The diff coverage is n/a.

❗ Current head 9c4c1c8 differs from pull request most recent head 61f05eb. Consider uploading reports for the commit 61f05eb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6167      +/-   ##
==========================================
- Coverage   89.70%   87.65%   -2.06%     
==========================================
  Files         318      318              
  Lines       41896    41893       -3     
==========================================
- Hits        37584    36722     -862     
- Misses       4312     5171     +859     
Impacted Files Coverage Δ
datalad/interface/results.py 96.15% <ø> (ø)
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/drop.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/remove.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981aa95...61f05eb. Read the comment docs.

@mih mih merged commit 9b201fc into datalad:master Nov 11, 2021
@mih mih deleted the doc-results branch November 11, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants