Design document on result records#6167
Merged
mih merged 1 commit intodatalad:masterfrom Nov 11, 2021
Merged
Conversation
adswa
reviewed
Nov 10, 2021
Member
|
I find this very helpful! Left a few comments |
adswa
reviewed
Nov 10, 2021
bpoldrack
reviewed
Nov 10, 2021
Developers are encouraged to amend this initial document with additional information, in particular field names that are in active use. Fixes datalad#6054 Fixes datalad#6171 [skip ci]
Codecov Report
@@ Coverage Diff @@
## master #6167 +/- ##
==========================================
- Coverage 89.70% 87.65% -2.06%
==========================================
Files 318 318
Lines 41896 41893 -3
==========================================
- Hits 37584 36722 -862
- Misses 4312 5171 +859
Continue to review full report at Codecov.
|
1 task
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developers are encouraged to amend this initial document with additional information, in particular field names that are in active use.
get_status_dict()can no longer handle any exception, requiresCapturedExceptionnow #6171Please suggest concrete changes/addition using the reviewing functionality of by pushing the this branch. Given the documentation-nature of this PR, I will merge this tomorrow, unless objections are expressed.