RM: (re)move get_func_kwargs_doc and some python2 compat code path#6175
Merged
mih merged 2 commits intodatalad:masterfrom Nov 11, 2021
Merged
RM: (re)move get_func_kwargs_doc and some python2 compat code path#6175mih merged 2 commits intodatalad:masterfrom
mih merged 2 commits intodatalad:masterfrom
Conversation
well -- inspect seems to still provide getargspec but since we used getfullargspec shim by default, no need to keep that alternative implementation which would be triggered only on python2 which we do no longer support
Codecov Report
@@ Coverage Diff @@
## master #6175 +/- ##
===========================================
- Coverage 89.70% 77.78% -11.93%
===========================================
Files 318 318
Lines 41896 41868 -28
===========================================
- Hits 37584 32566 -5018
- Misses 4312 9302 +4990
Continue to review full report at Codecov.
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be more but largely orthogonal so decided to submit this short quick PR.
It is a companion to datalad/datalad-crawler#113 which I marked for the release and just merged... https://pypi.org/project/datalad-crawler/ has 0.9.3 now
I didn't check other extensions if they use this elderly function -- will see with this PR