Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail dropping an uninitialized AnnexRepo #6183

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 11, 2021

Previously it would fail trying to determine whether the local
annex is known to remotes, but before init there is no local
annex.

With this change I am catching this condition and avoid the entire
investigation.

The potentially bigger issue (whether or not such a dataset should
carry an AnnexRepo instance, rather than GitRepo) is related
to #6103 and must be discussed separately.

Fixes #6180

Previously it would fail trying to determine whether the local
annex is known to remotes, but before `init` there is no local
annex.

With this change I am catching this condition and avoid the entire
investigation.

The potentially bigger issue (whether or not such a dataset should
carry an `AnnexRepo` instance, rather than `GitRepo`) is related
to datalad#6103 and must be discussed separately.

Fixes datalad#6180
@mih mih added the semver-patch Increment the patch version when merged label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #6183 (3c6da5b) into master (f240bdb) will decrease coverage by 15.16%.
The diff coverage is 55.69%.

❗ Current head 3c6da5b differs from pull request most recent head abb2457. Consider uploading reports for the commit abb2457 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6183       +/-   ##
===========================================
- Coverage   89.70%   74.54%   -15.17%     
===========================================
  Files         317      317               
  Lines       41635    41628        -7     
===========================================
- Hits        37350    31032     -6318     
- Misses       4285    10596     +6311     
Impacted Files Coverage Δ
datalad/core/distributed/tests/test_push.py 0.00% <0.00%> (-98.94%) ⬇️
datalad/core/local/tests/test_diff.py 0.00% <0.00%> (-99.54%) ⬇️
datalad/core/local/tests/test_results.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/core/local/tests/test_run.py 16.71% <ø> (-83.29%) ⬇️
datalad/core/local/tests/test_status.py 0.00% <0.00%> (-98.48%) ⬇️
...ad/distributed/tests/test_create_sibling_ghlike.py 69.69% <0.00%> (ø)
...talad/distributed/tests/test_create_sibling_ria.py 37.50% <0.00%> (-62.50%) ⬇️
datalad/distribution/create_sibling.py 64.73% <ø> (ø)
datalad/distribution/tests/test_get.py 100.00% <ø> (ø)
datalad/interface/common_opts.py 100.00% <ø> (ø)
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f240bdb...abb2457. Read the comment docs.

@mih mih merged commit 7d6f4b7 into datalad:master Nov 11, 2021
@mih mih deleted the bf-drop branch November 11, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove fails with confusing error
1 participant