Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Replace appdirs with platformdirs #6198

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 16, 2021

The original appdirs repository is unmaintained. This change replaces it
with a currently maintained fork of the project. Closes #6164, and for now replaces #6166

@adswa adswa added the semver-minor Increment the minor version when merged label Nov 16, 2021
The original appdirs repository is unmaintained. This change replaces it
with a currently maintained fork of the project. Closes datalad#6164
@adswa
Copy link
Member Author

adswa commented Nov 16, 2021

rebased to master and added semver-minor label as per Bens suggestion

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6198 (2d57aa4) into master (615910d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6198      +/-   ##
==========================================
- Coverage   89.71%   89.71%   -0.01%     
==========================================
  Files         319      319              
  Lines       41663    41717      +54     
==========================================
+ Hits        37378    37426      +48     
- Misses       4285     4291       +6     
Impacted Files Coverage Δ
datalad/interface/run_procedure.py 93.49% <ø> (ø)
datalad/support/external_versions.py 94.87% <ø> (ø)
datalad/cmdline/helpers.py 73.42% <100.00%> (ø)
datalad/downloaders/tests/test_providers.py 100.00% <100.00%> (ø)
datalad/interface/common_cfg.py 100.00% <100.00%> (ø)
datalad/support/cookies.py 80.88% <100.00%> (ø)
datalad/tests/test_utils.py 96.74% <0.00%> (-0.57%) ⬇️
datalad/distribution/dataset.py 96.26% <0.00%> (-0.38%) ⬇️
datalad/interface/base.py 89.51% <0.00%> (+0.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615910d...2d57aa4. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit 02f6914 into datalad:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using Appdirs
2 participants