Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: redistribute windows tests across workers to harmonize runtime #6200

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

adswa
Copy link
Member

@adswa adswa commented Nov 16, 2021

This is an attempt to fix #6193, but we will have to take a look at the actual runtimes with this change

@adswa adswa added the semver-tests Changes only affect tests, no impact on version label Nov 16, 2021
@adswa
Copy link
Member Author

adswa commented Nov 16, 2021

I have cancelled all CIs except for Appveyor, which should be the only thing affected by this change.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6200 (6c943cb) into master (615910d) will decrease coverage by 1.32%.
The diff coverage is 92.40%.

❗ Current head 6c943cb differs from pull request most recent head 5ed2f72. Consider uploading reports for the commit 5ed2f72 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6200      +/-   ##
==========================================
- Coverage   89.71%   88.39%   -1.33%     
==========================================
  Files         319      319              
  Lines       41663    41712      +49     
==========================================
- Hits        37378    36871     -507     
- Misses       4285     4841     +556     
Impacted Files Coverage Δ
datalad/support/external_versions.py 94.87% <ø> (ø)
datalad/tests/test_utils.py 96.07% <84.84%> (-1.25%) ⬇️
datalad/distribution/dataset.py 96.26% <85.71%> (-0.38%) ⬇️
datalad/interface/base.py 89.51% <100.00%> (+0.05%) ⬆️
datalad/interface/utils.py 91.33% <100.00%> (ø)
datalad/utils.py 83.66% <100.00%> (-1.01%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615910d...5ed2f72. Read the comment docs.

@adswa
Copy link
Member Author

adswa commented Nov 16, 2021

Screenshot from 2021-11-16 13-30-41

moving one more test around to improve this further

@adswa
Copy link
Member Author

adswa commented Nov 16, 2021

I think it is better balanced now:
Screenshot from 2021-11-16 14-56-35

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@mih mih merged commit f79c53f into datalad:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebalance runtime of windows CI runs on appveyor
2 participants